Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2526553002: Fix net_unittests when run in a virtualenv. (Closed)

Created:
4 years ago by mbjorge
Modified:
4 years ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix net_unittests when run in a virtualenv. Passing -S to python breaks in a virtualenv because it cannot find the stdlib modules (e.g. base64). Only pass -S if not already in a virtualenv. BUG=667897 TEST=net_unittests inside a virtualenv Committed: https://crrev.com/49e77410bb70d01e8377025eb6473eb6a7602afb Cr-Commit-Position: refs/heads/master@{#434739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M net/test/python_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/test/python_utils.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mbjorge
4 years ago (2016-11-22 20:04:41 UTC) #2
Ryan Hamilton
lgtm, but please wait for Paweł since he's more familiar with the code than I.
4 years ago (2016-11-22 20:20:44 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years ago (2016-11-25 07:45:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526553002/1
4 years ago (2016-11-28 17:49:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 22:31:49 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-28 22:35:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49e77410bb70d01e8377025eb6473eb6a7602afb
Cr-Commit-Position: refs/heads/master@{#434739}

Powered by Google App Engine
This is Rietveld 408576698