Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2526543003: Use more unique_ptrs in CPDF_SyntaxParser and CPDF_Annot (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use more unique_ptrs in CPDF_SyntaxParser and CPDF_Annot Committed: https://pdfium.googlesource.com/pdfium/+/c675a2f4afdd7e54bc4b4638bd1ffcb2de0b7124

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M core/fpdfapi/parser/cpdf_syntax_parser.h View 1 chunk +4 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_syntax_parser.cpp View 8 chunks +9 lines, -21 lines 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom Sepez
Lei, for review.
4 years ago (2016-11-22 20:17:22 UTC) #2
Lei Zhang
lgtm
4 years ago (2016-11-22 20:48:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526543003/1
4 years ago (2016-11-22 21:02:27 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-22 21:02:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c675a2f4afdd7e54bc4b4638bd1ffcb2de0b...

Powered by Google App Engine
This is Rietveld 408576698