Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: content/browser/media/session/pepper_player_delegate.cc

Issue 2526533002: Allow MediaSession in iframes to be routed (Closed)
Patch Set: addressed new commets from Anton Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/pepper_player_delegate.cc
diff --git a/content/browser/media/session/pepper_player_delegate.cc b/content/browser/media/session/pepper_player_delegate.cc
index 7b95734faa6b4ac566c07915eb635076c4e5f221..55f03c5c8139fecfe783df5c681f0a72f483a901 100644
--- a/content/browser/media/session/pepper_player_delegate.cc
+++ b/content/browser/media/session/pepper_player_delegate.cc
@@ -59,6 +59,10 @@ void PepperPlayerDelegate::OnSetVolumeMultiplier(int player_id,
SetVolume(player_id, volume_multiplier);
}
+RenderFrameHost* PepperPlayerDelegate::GetRenderFrameHost() const {
+ return nullptr;
whywhat 2016/12/01 22:13:00 if pepper player's RFH is always null, why do we i
Zhiqiang Zhang (Slow) 2016/12/02 14:17:28 Ditto http://crbug.com/670273. Added a TODO here.
+}
+
void PepperPlayerDelegate::SetVolume(int player_id, double volume) {
contents_->Send(new FrameMsg_SetPepperVolume(
contents_->GetMainFrame()->routing_id(), pp_instance_, volume));

Powered by Google App Engine
This is Rietveld 408576698