Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Unified Diff: content/browser/media/session/media_session_android.cc

Issue 2526533002: Allow MediaSession in iframes to be routed (Closed)
Patch Set: addressed new commets from Anton Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session_android.cc
diff --git a/content/browser/media/session/media_session_android.cc b/content/browser/media/session/media_session_android.cc
index 87971b4b57015d3830030875e2cabf4453c626cb..135e3043118c896b9d90da6d0dbebb5751e9706a 100644
--- a/content/browser/media/session/media_session_android.cc
+++ b/content/browser/media/session/media_session_android.cc
@@ -4,7 +4,7 @@
#include "content/browser/media/session/media_session_android.h"
-#include <algorithm>
+#include "base/android/jni_array.h"
#include "content/browser/media/session/media_session_impl.h"
#include "content/browser/web_contents/web_contents_android.h"
#include "content/browser/web_contents/web_contents_impl.h"
@@ -103,26 +103,19 @@ void MediaSessionAndroid::MediaSessionMetadataChanged(
j_metadata);
}
-void MediaSessionAndroid::MediaSessionEnabledAction(
- blink::mojom::MediaSessionAction action) {
+void MediaSessionAndroid::MediaSessionActionsChanged(
+ const std::set<blink::mojom::MediaSessionAction>& actions) {
ScopedJavaLocalRef<jobject> j_local_session = GetJavaObject();
if (j_local_session.is_null())
return;
- JNIEnv* env = base::android::AttachCurrentThread();
- Java_MediaSessionImpl_mediaSessionEnabledAction(env, j_local_session,
- static_cast<int>(action));
-}
-
-void MediaSessionAndroid::MediaSessionDisabledAction(
- blink::mojom::MediaSessionAction action) {
- ScopedJavaLocalRef<jobject> j_local_session = GetJavaObject();
- if (j_local_session.is_null())
- return;
+ std::vector<int> actions_vec;
+ for (auto action : actions)
+ actions_vec.push_back(static_cast<int>(action));
JNIEnv* env = base::android::AttachCurrentThread();
- Java_MediaSessionImpl_mediaSessionDisabledAction(env, j_local_session,
- static_cast<int>(action));
+ Java_MediaSessionImpl_mediaSessionActionsChanged(
+ env, j_local_session, base::android::ToJavaIntArray(env, actions_vec));
}
void MediaSessionAndroid::Resume(

Powered by Google App Engine
This is Rietveld 408576698