Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2304)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java

Issue 2526533002: Allow MediaSession in iframes to be routed (Closed)
Patch Set: addressed new commets from Anton Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
index 57c2dde165b714c12260e51f4ee81e1b3502d999..f10db2a3d9123e9193f579aa1ccbbecbb534d762 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
@@ -30,7 +30,6 @@ import org.chromium.ui.base.WindowAndroid;
import java.net.URI;
import java.net.URISyntaxException;
-import java.util.HashSet;
import java.util.Set;
import javax.annotation.Nullable;
@@ -61,7 +60,7 @@ public class MediaSessionTabHelper implements MediaImageCallback {
// The currently showing metadata.
private MediaMetadata mCurrentMetadata = null;
private MediaImageManager mMediaImageManager = null;
- private Set<Integer> mMediaSessionActions = new HashSet<Integer>();
+ private Set<Integer> mMediaSessionActions = null;
private Handler mHandler;
// The delayed task to hide notification. Hiding notification can be immediate or delayed.
// Delayed hiding will schedule this delayed task to |mHandler|. The task will be canceled when
@@ -228,16 +227,8 @@ public class MediaSessionTabHelper implements MediaImageCallback {
}
@Override
- public void mediaSessionEnabledAction(int action) {
- if (!MediaSessionAction.isKnownValue(action)) return;
- mMediaSessionActions.add(action);
- updateNotificationActions();
- }
-
- @Override
- public void mediaSessionDisabledAction(int action) {
- if (!MediaSessionAction.isKnownValue(action)) return;
- mMediaSessionActions.remove(action);
+ public void mediaSessionActionsChanged(Set<Integer> actions) {
+ mMediaSessionActions = actions;
updateNotificationActions();
}
};
@@ -261,7 +252,7 @@ public class MediaSessionTabHelper implements MediaImageCallback {
if (mMediaSessionObserver == null) return;
mMediaSessionObserver.stopObserving();
mMediaSessionObserver = null;
- mMediaSessionActions.clear();
+ mMediaSessionActions = null;
}
private final TabObserver mTabObserver = new EmptyTabObserver() {

Powered by Google App Engine
This is Rietveld 408576698