Make AnalysisSErver APIs to access unit/node/element asynchronous.

Make AnalysisSErver APIs to access unit/node/element asynchronous.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9f1ca4a119a08110e3edec5f803b99b3aac549a1

[Paul Berry, 2016-11-22 18:06:18]

lgtm

https://codereview.chromium.org/2526473003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2526473003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:709: * Return the [Future] that
completes with the [Element] at the given
s/Return the [Future]/Return a [Future]/

("Return the Future..." implies that there is some specific preexisting future
which the caller knows about that should be returned)

A similar comment fix needs to be made to getNodeAtOffset and
getResolvedCompilationUnit.

[Brian Wilkerson, 2016-11-22 18:13:27]

lgtm

[scheglov, 2016-11-22 18:45:47]

https://codereview.chromium.org/2526473003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/2526473003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:709: * Return the [Future] that
completes with the [Element] at the given
On 2016/11/22 18:06:18, Paul Berry wrote:
> s/Return the [Future]/Return a [Future]/
> 
> ("Return the Future..." implies that there is some specific preexisting future
> which the caller knows about that should be returned)
> 
> A similar comment fix needs to be made to getNodeAtOffset and
> getResolvedCompilationUnit.

Done.

[scheglov, 2016-11-22 18:46:17]

Description was changed from

==========
Make AnalysisSErver APIs to access unit/node/element asynchronous.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Make AnalysisSErver APIs to access unit/node/element asynchronous.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9f1ca4a119a08110e3edec5f803b99b3aac549a1
==========

[scheglov, 2016-11-22 18:46:18]

Committed patchset #1 (id:1) manually as
9f1ca4a119a08110e3edec5f803b99b3aac549a1 (presubmit successful).