Add FPDF_RenderPageBitmapWithMatrix.

Add FPDF_RenderPageBitmapWithMatrix API.

BUG=pdfium:522
Committed: https://pdfium.googlesource.com/pdfium/+/a78ba6043eafc9fd05481e64c37002b487357bbf

[Lei Zhang, 2016-11-22 10:48:17]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 10:48:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 11:00:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 11:00:09]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-22 14:21:26]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-11-22 14:21:27]

https://codereview.chromium.org/2526473002/diff/1/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2526473002/diff/1/fpdfsdk/fpdfview.cpp#newcode67
fpdfsdk/fpdfview.cpp:67: if (flags & FPDF_NO_NATIVETEXT)
blink line before to make it clear the if is separate from the else?

https://codereview.chromium.org/2526473002/diff/1/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/2526473002/diff/1/public/fpdfview.h#newcode624
public/fpdfview.h:624: //                          annotations that does not
require user-interaction,
nit: do not

[Lei Zhang, 2016-11-22 23:33:39]

Description was changed from

==========
Add FPDF_RenderPageBitmapWithMatrix.

BUG=pdfium:522
==========

to

==========
Add FPDF_RenderPageBitmapWithMatrix.

BUG=pdfium:522
==========

[Lei Zhang, 2016-11-22 23:33:39]

thestig@chromium.org changed reviewers:
+ moltmann@google.com

[Lei Zhang, 2016-11-22 23:55:11]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 23:55:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-11-22 23:56:07]

PTAL. Added a test with some simple transformations to make sure it renders how
I think it should render.

https://codereview.chromium.org/2526473002/diff/1/fpdfsdk/fpdfview.cpp
File fpdfsdk/fpdfview.cpp (right):

https://codereview.chromium.org/2526473002/diff/1/fpdfsdk/fpdfview.cpp#newcode67
fpdfsdk/fpdfview.cpp:67: if (flags & FPDF_NO_NATIVETEXT)
On 2016/11/22 14:21:27, dsinclair wrote:
> blink line before to make it clear the if is separate from the else?

Sure. This is all moved code.

https://codereview.chromium.org/2526473002/diff/1/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/2526473002/diff/1/public/fpdfview.h#newcode624
public/fpdfview.h:624: //                          annotations that does not
require user-interaction,
On 2016/11/22 14:21:27, dsinclair wrote:
> nit: do not

Done.

[Lei Zhang, 2016-11-22 23:56:15]

Description was changed from

==========
Add FPDF_RenderPageBitmapWithMatrix.

BUG=pdfium:522
==========

to

==========
Add FPDF_RenderPageBitmapWithMatrix API.

BUG=pdfium:522
==========

[commit-bot: I haz the power, 2016-11-23 00:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:07:11]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-23 14:08:44]

lgtm w/ nits.

https://codereview.chromium.org/2526473002/diff/60001/fpdfsdk/fpdfview_embedd...
File fpdfsdk/fpdfview_embeddertest.cpp (right):

https://codereview.chromium.org/2526473002/diff/60001/fpdfsdk/fpdfview_embedd...
fpdfsdk/fpdfview_embeddertest.cpp:348: matrix.a = 1;
Can you add a comment as to what the matrix here, and the one below do? I'm
guessing this is identity and the one below is scale but I them hard to read ...

https://codereview.chromium.org/2526473002/diff/60001/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/2526473002/diff/60001/public/fpdfview.h#newco...
public/fpdfview.h:622: //          flags       -   0 for normal display, or
combination of flags
combination of the Page Rendering flags defined above.

https://codereview.chromium.org/2526473002/diff/60001/public/fpdfview.h#newco...
public/fpdfview.h:623: //                          defined above. With
FPDF_ANNOT flag, it renders all
With the

[Lei Zhang, 2016-11-23 18:30:31]

Going to wait for moltmann to sign off.

https://codereview.chromium.org/2526473002/diff/60001/fpdfsdk/fpdfview_embedd...
File fpdfsdk/fpdfview_embeddertest.cpp (right):

https://codereview.chromium.org/2526473002/diff/60001/fpdfsdk/fpdfview_embedd...
fpdfsdk/fpdfview_embeddertest.cpp:348: matrix.a = 1;
On 2016/11/23 14:08:44, dsinclair wrote:
> Can you add a comment as to what the matrix here, and the one below do? I'm
> guessing this is identity and the one below is scale but I them hard to read
...

Done.

https://codereview.chromium.org/2526473002/diff/60001/public/fpdfview.h
File public/fpdfview.h (right):

https://codereview.chromium.org/2526473002/diff/60001/public/fpdfview.h#newco...
public/fpdfview.h:622: //          flags       -   0 for normal display, or
combination of flags
On 2016/11/23 14:08:44, dsinclair wrote:
> combination of the Page Rendering flags defined above.

Done.

https://codereview.chromium.org/2526473002/diff/60001/public/fpdfview.h#newco...
public/fpdfview.h:623: //                          defined above. With
FPDF_ANNOT flag, it renders all
On 2016/11/23 14:08:44, dsinclair wrote:
> With the

Done.

[Lei Zhang, 2016-11-23 23:11:08]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-11-23 23:11:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2526473002/#ps80001
(title: "rebase, nits")

[commit-bot: I haz the power, 2016-11-23 23:11:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:25:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1479942668096140,
"parent_rev": "4e847e36fe013bcfddf71c79221887a308b9fadb", "commit_rev":
"a78ba6043eafc9fd05481e64c37002b487357bbf"}

[commit-bot: I haz the power, 2016-11-23 23:25:51]

Description was changed from

==========
Add FPDF_RenderPageBitmapWithMatrix API.

BUG=pdfium:522
==========

to

==========
Add FPDF_RenderPageBitmapWithMatrix API.

BUG=pdfium:522

Committed:
https://pdfium.googlesource.com/pdfium/+/a78ba6043eafc9fd05481e64c37002b48735...
==========

[commit-bot: I haz the power, 2016-11-23 23:25:52]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/a78ba6043eafc9fd05481e64c37002b48735...