Remove duplicate text in description of ExternalStorageReadOnly

Remove duplicate text in description of ExternalStorageReadOnly

BUG=629945
Committed: https://crrev.com/66317b3bdfba989c119002a81390d8e265fdbd29
Cr-Commit-Position: refs/heads/master@{#434498}

[Thiemo Nagel, 2016-11-22 10:29:52]

tnagel@chromium.org changed reviewers:
+ atwilson@chromium.org, bartfab@chromium.org, yamaguchi@chromium.org

[Thiemo Nagel, 2016-11-22 10:29:53]

Please don't repeat the caption as the first sentence of the description as this
shows up as duplicated lines in chrome_settings.proto.

[Thiemo Nagel, 2016-11-22 10:30:07]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 10:30:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 12:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 12:22:57]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2016-11-24 04:26:39]

lgtm

[Thiemo Nagel, 2016-11-24 09:52:23]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-24 09:52:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 11:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 11:53:51]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Thiemo Nagel, 2016-11-24 11:55:03]

Looks like a CQ problem, retrying...

[Thiemo Nagel, 2016-11-24 11:55:09]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-24 11:55:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:56:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:56:46]

Exceeded global retry quota

[Thiemo Nagel, 2016-11-24 14:04:15]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-24 14:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 15:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:20:39]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Thiemo Nagel, 2016-11-24 16:46:28]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-24 16:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 17:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 17:53:17]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Thiemo Nagel, 2016-11-25 13:52:26]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-11-25 13:52:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Andrew T Wilson (Slow), 2016-11-25 14:25:13]

https://codereview.chromium.org/2526463002/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2526463002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:5813: 'desc': '''This policy
is effective only when ExternalStorageDisabled is set to false or not
configured.
What does this mean, exactly? It sure seems like this policy is effective when
ExternalStorageDisabled is set to true - if not, what's the point of having this
policy at all?

https://codereview.chromium.org/2526463002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:5817: If this setting is
disabled or not configured then users can create and modify files of external
storage devices which are physically writable.
"setting is disabled" is unclear.  Should we say "set to false" instead? There's
no such thing as setting a policy as disabled.

[bartfab (slow), 2016-11-25 14:29:38]

Yay for policies with negative polarity.

[commit-bot: I haz the power, 2016-11-25 14:33:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480081946060080, "parent_rev":
"f91ff7dde33962da867ce40d6485257fe9b639a1", "commit_rev":
"59eafb822c57200a84e4a998a178c941e859334c"}

[commit-bot: I haz the power, 2016-11-25 14:33:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-25 14:36:31]

Description was changed from

==========
Remove duplicate text in description of ExternalStorageReadOnly

BUG=629945
==========

to

==========
Remove duplicate text in description of ExternalStorageReadOnly

BUG=629945

Committed: https://crrev.com/66317b3bdfba989c119002a81390d8e265fdbd29
Cr-Commit-Position: refs/heads/master@{#434498}
==========

[commit-bot: I haz the power, 2016-11-25 14:36:32]

Patchset 1 (id:??) landed as
https://crrev.com/66317b3bdfba989c119002a81390d8e265fdbd29
Cr-Commit-Position: refs/heads/master@{#434498}

[Thiemo Nagel, 2016-11-25 15:02:20]

https://codereview.chromium.org/2526463002/diff/1/components/policy/resources...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2526463002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:5813: 'desc': '''This policy
is effective only when ExternalStorageDisabled is set to false or not
configured.
On 2016/11/25 14:25:13, Andrew T Wilson (Slow) wrote:
> What does this mean, exactly? It sure seems like this policy is effective when
> ExternalStorageDisabled is set to true - if not, what's the point of having
this
> policy at all?

I'm leaving this to Tatsuhisa for follow-up.

https://codereview.chromium.org/2526463002/diff/1/components/policy/resources...
components/policy/resources/policy_templates.json:5817: If this setting is
disabled or not configured then users can create and modify files of external
storage devices which are physically writable.
On 2016/11/25 14:25:13, Andrew T Wilson (Slow) wrote:
> "setting is disabled" is unclear.  Should we say "set to false" instead?
There's
> no such thing as setting a policy as disabled.

I'm leaving this to Tatsuhisa for follow-up.