Remove --use-spelling-suggestions flag.

chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc

Index: chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc b/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
index 1cde7c6fa16b094558b1d428c9b5af9f94809018..84b4fd468c5985758e11b43f2f7e639f8357a02a 100644
--- a/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
@@ -324,11 +324,9 @@ IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, EnableSpellingService) {
 // SpellingServiceClient::SUGGEST is on.
 IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, SeparatorAfterSuggestions) {
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
-  CommandLine* command_line = CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kUseSpellingSuggestions);
 
-  // Force a non-empty locale so SUGGEST is available.
-  menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "en");
+  // Force a non-empty and non-"en" locale so SUGGEST is available.

[groby-ooo-7-16, 2014/04/28 22:52:30]

Since we're forcing "fr" in two places now,  I'd suggest rolling this into a
helper func

void ForceSuggestMode() {Profile* profile, Prefs* prefs) {
  prefs->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
      CommandLine* command_line = CommandLine::ForCurrentProcess();
  prefs->SetString(prefs::kSpellCheckDictionary, "fr");
  ASSERT(SpellingServiceClient::IsAvailable(profile,
SpellingServiceClient::SUGGEST));
}

That way, we won't accidentally miss things once we enable "fr" for
spellchecking.

[please use gerrit instead, 2014/04/29 03:11:33]

Done.

+  menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "fr");
   EXPECT_TRUE(SpellingServiceClient::IsAvailable(menu()->GetProfile(),
     SpellingServiceClient::SUGGEST));
 
@@ -468,8 +466,7 @@ IN_PROC_BROWSER_TEST_F(SpellingMenuObserverTest, SuggestionsForceTopSeparator) {
   // Case #3. Misspelled word, suggestion service is on.
   Reset(false);
   menu()->GetPrefs()->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
-  CommandLine* command_line = CommandLine::ForCurrentProcess();
-  command_line->AppendSwitch(switches::kUseSpellingSuggestions);
+  menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "fr");

[groby-ooo-7-16, 2014/04/28 22:52:30]

See above re: "fr"

[please use gerrit instead, 2014/04/29 03:11:33]

Done.

   InitMenu("asdfkj", NULL);
 
   // Should have at least 2 entries. Separator, suggestion.