Remove --use-spelling-suggestions flag.

Remove --use-spelling-suggestions flag.

BUG=344006
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267615

[please use gerrit instead, 2014-04-28 22:27:06]

Groby: PTAL Patch Set 1.

[groby-ooo-7-16, 2014-04-28 22:52:30]

LGTM w/nit

https://codereview.chromium.org/252643004/diff/1/chrome/browser/renderer_cont...
File chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
(right):

https://codereview.chromium.org/252643004/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc:328:
// Force a non-empty and non-"en" locale so SUGGEST is available.
Since we're forcing "fr" in two places now,  I'd suggest rolling this into a
helper func

void ForceSuggestMode() {Profile* profile, Prefs* prefs) {
  prefs->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
      CommandLine* command_line = CommandLine::ForCurrentProcess();
  prefs->SetString(prefs::kSpellCheckDictionary, "fr");
  ASSERT(SpellingServiceClient::IsAvailable(profile,
SpellingServiceClient::SUGGEST));
}

That way, we won't accidentally miss things once we enable "fr" for
spellchecking.

https://codereview.chromium.org/252643004/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc:469:
menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "fr");
See above re: "fr"

[please use gerrit instead, 2014-04-29 03:11:32]

Sending to CQ.

https://codereview.chromium.org/252643004/diff/1/chrome/browser/renderer_cont...
File chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc
(right):

https://codereview.chromium.org/252643004/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc:328:
// Force a non-empty and non-"en" locale so SUGGEST is available.
On 2014/04/28 22:52:30, groby wrote:
> Since we're forcing "fr" in two places now,  I'd suggest rolling this into a
> helper func
> 
> void ForceSuggestMode() {Profile* profile, Prefs* prefs) {
>   prefs->SetBoolean(prefs::kSpellCheckUseSpellingService, true);
>       CommandLine* command_line = CommandLine::ForCurrentProcess();
>   prefs->SetString(prefs::kSpellCheckDictionary, "fr");
>   ASSERT(SpellingServiceClient::IsAvailable(profile,
> SpellingServiceClient::SUGGEST));
> }
> 
> That way, we won't accidentally miss things once we enable "fr" for
> spellchecking.
> 
> 
> 

Done.

https://codereview.chromium.org/252643004/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc:469:
menu()->GetPrefs()->SetString(prefs::kSpellCheckDictionary, "fr");
On 2014/04/28 22:52:30, groby wrote:
> See above re: "fr"

Done.

[please use gerrit instead, 2014-04-29 03:11:44]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-04-29 03:12:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/252643004/20001

[commit-bot: I haz the power, 2014-04-29 03:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 03:26:33]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[please use gerrit instead, 2014-04-29 15:38:59]

Brett: PTAL
chrome/browser/renderer_context_menu/spelling_menu_observer_browsertest.cc.

[brettw, 2014-05-01 19:59:17]

lgtm

[please use gerrit instead, 2014-05-01 19:59:59]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-05-01 20:00:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rouslan@chromium.org/252643004/20001

[commit-bot: I haz the power, 2014-05-01 20:09:35]

Change committed as 267615