Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 252643002: Additional debugging for gaia login. (Closed)

Created:
6 years, 8 months ago by achuithb
Modified:
6 years, 8 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Additional debugging for gaia login. * Use Oobe.addUserForTesting instead of chrome.send * Merge multiple invocations of EvaluateJavaScriptInContext * Take a screenshot if we time out on finding _GaiaLoginContext * Increase timeout to find _GaiaLoginContext. * Add a disabled test - test is disabled since it hits live gaia. BUG=361862 TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266078

Patch Set 1 #

Patch Set 2 : remove username/passwd #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 2 2 chunks +17 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
achuithb
Tim, please review.
6 years, 8 months ago (2014-04-24 23:51:55 UTC) #1
Tim Song
lgtm
6 years, 8 months ago (2014-04-25 00:26:24 UTC) #2
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 8 months ago (2014-04-25 00:51:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/252643002/40001
6 years, 8 months ago (2014-04-25 00:52:52 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 01:04:38 UTC) #5
Message was sent while issue was closed.
Change committed as 266078

Powered by Google App Engine
This is Rietveld 408576698