Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2526383002: Revert of Disable Precompile-platform with clang-cl. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable Precompile-platform with clang-cl. (patchset #1 id:1 of https://codereview.chromium.org/2520833005/ ) Reason for revert: The crash is now hopefully fixed in clang-cl. Original issue's description: > Disable Precompile-platform with clang-cl. > > It currently asserts while trying to build that PCH file. > > BUG=667891, 495697 > NOTRY=true > > Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3 > Cr-Commit-Position: refs/heads/master@{#434028} TBR=rnk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=667891, 495697 Committed: https://crrev.com/a0eb8ed36a1c3e2c5becc95ef03d42655c7cd95c Cr-Commit-Position: refs/heads/master@{#434534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Nico
Created Revert of Disable Precompile-platform with clang-cl.
4 years ago (2016-11-24 20:20:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526383002/1
4 years ago (2016-11-24 20:20:59 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/321924)
4 years ago (2016-11-24 21:08:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526383002/1
4 years ago (2016-11-25 16:47:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 17:32:39 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a0eb8ed36a1c3e2c5becc95ef03d42655c7cd95c Cr-Commit-Position: refs/heads/master@{#434534}
4 years ago (2016-11-25 17:34:29 UTC) #11
Reid Kleckner
4 years ago (2016-11-28 19:57:56 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2533853003/ by rnk@chromium.org.

The reason for reverting is: Clang still asserts when building
Precompile-core.obj, but it's somewhere else:
Assertion failed: AllowUnresolvedNodes && "Cannot handle unresolved nodes"....

Powered by Google App Engine
This is Rietveld 408576698