Add AnalysisDriver.getIndex().

Add AnalysisDriver.getIndex().

AnalysisResult.index is not quite enough.

While the index can be used to find where an element is used in the file,
we need to know also the enclosing Element, which we can find from the
full CompilationUnitElement.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/a69b7f3fb0079124e647932b4fcf8f91ea335276

[Paul Berry, 2016-11-25 15:08:51]

lgtm

https://codereview.chromium.org/2526373002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2526373002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:586: * TODO(scheglov) document
Would you mind adding documentation before committing?

Alternatively I think it would be ok to leave the comment out, since this is a
private method and its behavior is pretty self-explanatory.

[scheglov, 2016-11-25 17:48:15]

https://codereview.chromium.org/2526373002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2526373002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:586: * TODO(scheglov) document
On 2016/11/25 15:08:51, Paul Berry wrote:
> Would you mind adding documentation before committing?
> 
> Alternatively I think it would be ok to leave the comment out, since this is a
> private method and its behavior is pretty self-explanatory.

Done.

[scheglov, 2016-11-25 17:51:10]

Description was changed from

==========
Add AnalysisDriver.getIndex().

AnalysisResult.index is not quite enough.

While the index can be used to find where an element is used in the file,
we need to know also the enclosing Element, which we can find from the
full CompilationUnitElement.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add AnalysisDriver.getIndex().

AnalysisResult.index is not quite enough.

While the index can be used to find where an element is used in the file,
we need to know also the enclosing Element, which we can find from the
full CompilationUnitElement.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/a69b7f3fb0079124e647932b4fcf8f91ea335276
==========

[scheglov, 2016-11-25 17:51:12]

Committed patchset #1 (id:1) manually as
a69b7f3fb0079124e647932b4fcf8f91ea335276 (presubmit successful).

[Brian Wilkerson, 2016-11-28 16:59:21]

lgtm

https://codereview.chromium.org/2526373002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2526373002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:162: * [getIndex] to the
[Completer] to report the result.
"which index" --> "which an index" or "which the index"

"to the [Completer]"

It appears that it actually maps to a list of completers (which I guess means
that we could have multiple invocations of getIndex prior to the index actually
being computed). The comment should be updated to reflect that.