Fix for search references when the element is null.

Fix for search references when the element is null.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5cbd8247624365491102c3f153ff20e920105f1a

[Brian Wilkerson, 2016-11-28 16:40:15]

Assuming the notification is sent, lgtm.

https://codereview.chromium.org/2526363002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/search/search_domain.dart (right):

https://codereview.chromium.org/2526363002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/search/search_domain.dart:82:
_sendSearchNotification(searchId, true, results);
If element is null, will we still send a search notification? It seems like
clients ought to be able to count on getting at least one notification
indicating that there won't be any more notifications (isLast == true).

[scheglov, 2016-11-28 16:49:40]

https://codereview.chromium.org/2526363002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/search/search_domain.dart (right):

https://codereview.chromium.org/2526363002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/search/search_domain.dart:82:
_sendSearchNotification(searchId, true, results);
On 2016/11/28 16:40:15, Brian Wilkerson wrote:
> If element is null, will we still send a search notification? It seems like
> clients ought to be able to count on getting at least one notification
> indicating that there won't be any more notifications (isLast == true).

We don't need to.

According to the protocol: "If no element was found at the given location, this
field (id) will be absent, and no results will be reported via the
search.results notification."

[scheglov, 2016-11-28 16:51:45]

Description was changed from

==========
Fix for search references when the element is null.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Fix for search references when the element is null.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5cbd8247624365491102c3f153ff20e920105f1a
==========

[scheglov, 2016-11-28 16:51:46]

Committed patchset #1 (id:1) manually as
5cbd8247624365491102c3f153ff20e920105f1a (presubmit successful).