ash: Cleanup class/struct forward declarations

ash: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in ash header files.

BUG=662195
Committed: https://crrev.com/6d4442b6cdb8866d5117d0ac7496d443db446e93
Cr-Commit-Position: refs/heads/master@{#434549}

[jbriance, 2016-11-24 17:41:07]

jbriance@cisco.com changed reviewers:
+ derat@chromium.org, oshima@chromium.org, sky@chromium.org

[Daniel Erat, 2016-11-25 16:39:59]

lgtm

(probably better to just cc a single OWNERS reviewer unless you actually need
them all to take a look)

https://codereview.chromium.org/2526333002/diff/1/ash/wm/toplevel_window_even...
File ash/wm/toplevel_window_event_handler.h (left):

https://codereview.chromium.org/2526333002/diff/1/ash/wm/toplevel_window_even...
ash/wm/toplevel_window_event_handler.h:26: class WmGloblals;
heh, this one wasn't even spelled correctly. :-P

[jbriance, 2016-11-25 16:43:59]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 16:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbriance, 2016-11-25 16:47:38]

jbriance@cisco.com changed reviewers:
- oshima@chromium.org, sky@chromium.org

[jbriance, 2016-11-25 16:47:39]

> probably better to just cc a single OWNERS reviewer
> unless you actually need them all to take a look

I didn't know who I should target here, so I took all OWNERS. Removing oshima
and sky.

https://codereview.chromium.org/2526333002/diff/1/ash/wm/toplevel_window_even...
File ash/wm/toplevel_window_event_handler.h (left):

https://codereview.chromium.org/2526333002/diff/1/ash/wm/toplevel_window_even...
ash/wm/toplevel_window_event_handler.h:26: class WmGloblals;
On 2016/11/25 16:39:59, Daniel Erat wrote:
> heh, this one wasn't even spelled correctly. :-P

Hehe :)

[commit-bot: I haz the power, 2016-11-25 17:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 17:02:10]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[jbriance, 2016-11-25 17:09:37]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 17:09:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 17:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 17:44:56]

Dry run: This issue passed the CQ dry run.

[jbriance, 2016-11-25 17:46:23]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-25 17:46:23]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2526333002/#ps20001
(title: "Add missing forward declaration to fix build")

[commit-bot: I haz the power, 2016-11-25 17:46:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 17:51:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 17:51:13]

Failed to apply patch for ash/common/system/tray/tray_popup_utils.h:
While running git apply --index -p1;
  error: patch failed: ash/common/system/tray/tray_popup_utils.h:11
  error: ash/common/system/tray/tray_popup_utils.h: patch does not apply

Patch:       ash/common/system/tray/tray_popup_utils.h
Index: ash/common/system/tray/tray_popup_utils.h
diff --git a/ash/common/system/tray/tray_popup_utils.h
b/ash/common/system/tray/tray_popup_utils.h
index
f299257ee667063dad8c5dd2eccd8bc11c47e1b8..df0e8251e4dd8e4ea71e5eb98ed1abe169efed9f
100644
--- a/ash/common/system/tray/tray_popup_utils.h
+++ b/ash/common/system/tray/tray_popup_utils.h
@@ -11,7 +11,6 @@
 #include "base/strings/string16.h"
 
 namespace views {
-class Border;
 class ButtonListener;
 class ImageView;
 class InkDrop;
@@ -21,7 +20,6 @@ class InkDropHostView;
 class InkDropMask;
 class Label;
 class LabelButton;
-class LayoutManager;
 class Separator;
 class Slider;
 class SliderListener;

[jbriance, 2016-11-25 17:57:00]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 17:57:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 20:15:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 20:15:17]

Dry run: This issue passed the CQ dry run.

[jbriance, 2016-11-25 21:10:18]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-25 21:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2526333002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-25 21:10:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 21:15:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480108218382700,
"parent_rev": "3f3a42a5d5e522510f21703d76f0242c905bf69b", "commit_rev":
"85c640bb29e58f01bf816993890e95e5e179acc2"}

[commit-bot: I haz the power, 2016-11-25 21:16:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-25 21:18:02]

Description was changed from

==========
ash: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in ash header files.

BUG=662195
==========

to

==========
ash: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in ash header files.

BUG=662195

Committed: https://crrev.com/6d4442b6cdb8866d5117d0ac7496d443db446e93
Cr-Commit-Position: refs/heads/master@{#434549}
==========

[commit-bot: I haz the power, 2016-11-25 21:18:03]

Patchset 3 (id:??) landed as
https://crrev.com/6d4442b6cdb8866d5117d0ac7496d443db446e93
Cr-Commit-Position: refs/heads/master@{#434549}