content/browser/service_worker/embedded_worker_registry.cc - Issue 252633003: Introduce worker_devtools_agent_route_id for EmbeddedWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_registry.cc

Issue 252633003: Introduce worker_devtools_agent_route_id for EmbeddedWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated kinuko's comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.h ('K') | « content/browser/service_worker/embedded_worker_registry.h ('k') | content/browser/service_worker/embedded_worker_test_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_registry.cc

diff --git a/content/browser/service_worker/embedded_worker_registry.cc b/content/browser/service_worker/embedded_worker_registry.cc

index 249eab082b21ce3100114299d1da2811217b671b..a36cb187e505d052003b2c4b5b57b5b6839b1b19 100644

--- a/content/browser/service_worker/embedded_worker_registry.cc

+++ b/content/browser/service_worker/embedded_worker_registry.cc

@@ -5,6 +5,7 @@

#include "content/browser/service_worker/embedded_worker_registry.h"

#include "base/stl_util.h"

+#include "content/browser/renderer_host/render_process_host_impl.h"

#include "content/browser/service_worker/embedded_worker_instance.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/common/service_worker/embedded_worker_messages.h"

@@ -30,11 +31,17 @@ ServiceWorkerStatusCode EmbeddedWorkerRegistry::StartWorker(

int embedded_worker_id,

int64 service_worker_version_id,

const GURL& scope,

- const GURL& script_url) {

+ const GURL& script_url,

+ int* worker_devtools_agent_route_id) {

+ *worker_devtools_agent_route_id =

+ RenderProcessHostImpl::GetNextRoutingIDForProcess(process_id);

return Send(

process_id,

- new EmbeddedWorkerMsg_StartWorker(

- embedded_worker_id, service_worker_version_id, scope, script_url));

+ new EmbeddedWorkerMsg_StartWorker(embedded_worker_id,

+ service_worker_version_id,

+ scope,

+ script_url,

+ *worker_devtools_agent_route_id));

}

ServiceWorkerStatusCode EmbeddedWorkerRegistry::StopWorker(