content/browser/service_worker/service_worker_dispatcher_host.h - Issue 252633003: Introduce worker_devtools_agent_route_id for EmbeddedWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 252633003: Introduce worker_devtools_agent_route_id for EmbeddedWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Create NextRoutingIDCallback from widget_helper_ in RenderProcessHostImpl. Rename worker_route_id to worker_devtools_agent_route_id and change the order. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_registry.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.h

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.h b/content/browser/service_worker/service_worker_dispatcher_host.h

index 473f239c9caacba90672709e3d87f04d10fc6f89..307bad64e46a7d0b4501746a16edcf47ade00d0c 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.h

+++ b/content/browser/service_worker/service_worker_dispatcher_host.h

@@ -5,6 +5,7 @@

#ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_HOST_H_

#define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_DISPATCHER_HOST_H_

+#include "base/callback.h"

#include "base/id_map.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string16.h"

@@ -29,7 +30,8 @@ class CONTENT_EXPORT ServiceWorkerDispatcherHost : public BrowserMessageFilter {

int render_process_id,

MessagePortMessageFilter* message_port_message_filter);

- void Init(ServiceWorkerContextWrapper* context_wrapper);

+ void Init(ServiceWorkerContextWrapper* context_wrapper,

+ const base::Callback<int(void)>& next_routing_id_callback);

kinuko 2014/04/25 13:56:57 The new parameter needs a descriptive comment.

michaeln 2014/04/25 19:29:50 descriptive name would be even better

// BrowserIOMessageFilter implementation

virtual void OnDestruct() const OVERRIDE;