chrome/browser/resources/md_downloads/item.js - Issue 2526323004: Remove XSS from chrome://downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/item.js

Issue 2526323004: Remove XSS from chrome://downloads (Closed)

Patch Set: Declare dependency on util for HTMLEscape Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_downloads/item.js

diff --git a/chrome/browser/resources/md_downloads/item.js b/chrome/browser/resources/md_downloads/item.js

index 5ef69bfb046b34ea00b9308da7519e354f659fd9..00a3716f6a3ac235f0b2dc92244be8615b10c772 100644

--- a/chrome/browser/resources/md_downloads/item.js

+++ b/chrome/browser/resources/md_downloads/item.js

@@ -116,7 +116,7 @@ cr.define('downloads', function() {

var url = 'chrome://extensions#' + this.data.by_ext_id;

var name = this.data.by_ext_name;

- return loadTimeData.getStringF('controlledByUrl', url, name);

+ return loadTimeData.getStringF('controlledByUrl', url, HTMLEscape(name));

Dan Beam 2016/11/29 04:29:53 why escape just name?

robwu 2016/11/29 08:26:22 The extension ID is always a sequence of 32 charac

/** @private */

« no previous file with comments | « chrome/browser/resources/md_downloads/compiled_resources2.gyp ('k') | no next file » | no next file with comments »