[NTP Snippets] NTPSnippet cleanup: Make ctor take all IDs at once

components/ntp_snippets/remote/ntp_snippet.h

Index: components/ntp_snippets/remote/ntp_snippet.h
diff --git a/components/ntp_snippets/remote/ntp_snippet.h b/components/ntp_snippets/remote/ntp_snippet.h
index b82402c5c41da4c4cf878a7db68824f8206c4044..82a5cf6379b6b3ab3df7288049b438c279ef3e97 100644
--- a/components/ntp_snippets/remote/ntp_snippet.h
+++ b/components/ntp_snippets/remote/ntp_snippet.h
@@ -32,8 +32,7 @@ class NTPSnippet {
 
   // Public only so that MakeUnique will work. Don't use directly, call one of
   // the CreateFrom* methods below instead.

[tschumann, 2016/11/25 15:55:26]

Here's a nice discussion around this topic:
https://yaqs.googleplex.com/eng/q/5099710530453504 

I'd suggest to have a private helper function MakeUnique(...) which calls new
and wraps it into a unique_ptr.

[Marc Treib, 2016/11/25 16:57:36]

Done.

-  // TODO(treib): Make the constructor take the vector of IDs and remove AddIDs.
-  NTPSnippet(const std::string& id, int remote_category_id);
+  NTPSnippet(const std::vector<std::string>& ids, int remote_category_id);
   ~NTPSnippet();
 
   // Creates an NTPSnippet from a dictionary, as returned by Chrome Reader.
@@ -121,8 +120,6 @@ class NTPSnippet {
   static std::string TimeToJsonString(const base::Time& time);
 
  private:
-  void AddIDs(const std::vector<std::string>& ids);
-
   // The first ID in the vector is the primary id.
   std::vector<std::string> ids_;
   std::string title_;