Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2526313002: [NTP Snippets] NTPSnippet cleanup: Make ctor take all IDs at once (Closed)

Created:
4 years ago by Marc Treib
Modified:
4 years ago
Reviewers:
jkrcal, tschumann
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] NTPSnippet cleanup: Make ctor take all IDs at once BUG=655099 Committed: https://crrev.com/2d688b9e4edab7bb544fa5929817faee83d1df67 Cr-Commit-Position: refs/heads/master@{#434635}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 5

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -63 lines) Patch
M components/ntp_snippets/remote/ntp_snippet.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M components/ntp_snippets/remote/ntp_snippet.cc View 1 2 8 chunks +57 lines, -58 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Marc Treib
And one more small cleanup :) https://codereview.chromium.org/2526313002/diff/20001/components/ntp_snippets/remote/ntp_snippet.cc File components/ntp_snippets/remote/ntp_snippet.cc (left): https://codereview.chromium.org/2526313002/diff/20001/components/ntp_snippets/remote/ntp_snippet.cc#oldcode105 components/ntp_snippets/remote/ntp_snippet.cc:105: std::unique_ptr<NTPSnippet> snippet(new NTPSnippet(id, ...
4 years ago (2016-11-25 14:22:51 UTC) #2
tschumann
lgtm with nits https://codereview.chromium.org/2526313002/diff/20001/components/ntp_snippets/remote/ntp_snippet.cc File components/ntp_snippets/remote/ntp_snippet.cc (right): https://codereview.chromium.org/2526313002/diff/20001/components/ntp_snippets/remote/ntp_snippet.cc#newcode101 components/ntp_snippets/remote/ntp_snippet.cc:101: std::string id; nit: rename 'id' to ...
4 years ago (2016-11-25 15:55:26 UTC) #3
Marc Treib
https://codereview.chromium.org/2526313002/diff/20001/components/ntp_snippets/remote/ntp_snippet.cc File components/ntp_snippets/remote/ntp_snippet.cc (right): https://codereview.chromium.org/2526313002/diff/20001/components/ntp_snippets/remote/ntp_snippet.cc#newcode101 components/ntp_snippets/remote/ntp_snippet.cc:101: std::string id; On 2016/11/25 15:55:26, tschumann wrote: > nit: ...
4 years ago (2016-11-25 16:57:36 UTC) #5
Marc Treib
Once more, +jkrcal for approval. PTAL!
4 years ago (2016-11-25 16:58:04 UTC) #8
jkrcal
On 2016/11/25 16:58:04, Marc Treib wrote: > Once more, +jkrcal for approval. PTAL! lgtm
4 years ago (2016-11-28 10:47:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526313002/40001
4 years ago (2016-11-28 10:52:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-28 11:43:41 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-28 11:46:19 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2d688b9e4edab7bb544fa5929817faee83d1df67
Cr-Commit-Position: refs/heads/master@{#434635}

Powered by Google App Engine
This is Rietveld 408576698