Refactor DirectoryContents.

Refactor DirectoryContents.

Shares most of methods in DirectoryContents and its sub classes. Removes
all sub classes of DirectoryContents, instead create factory method.

BUG=279614
TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*:*FileBrowserPrivateApiTest*" and tested manually.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226467

[hidehiko, 2013-09-30 17:26:33]

This is based on crrev.com/25278002, which I asked to you to review.
If you think your review for that CL will affect to this CL, too, please feel
free to stop the review until it is fixed.

Thank you for your review in advance,
- hidehiko

[mtomasz, 2013-10-01 02:38:12]

https://codereview.chromium.org/25263003/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/25263003/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:487:
this.context_, this.isSearch, this.directoryEntry_,
nit: this.isSearch -> this.isSearch_

https://codereview.chromium.org/25263003/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:750: * on Drive
File System.
nit: Please add a new line after the description for long jsdocs.

[hidehiko, 2013-10-01 07:38:54]

Thank you for your review, and sorry, rebase has been mixed... PTAL?

https://codereview.chromium.org/25263003/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/25263003/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:487:
this.context_, this.isSearch, this.directoryEntry_,
On 2013/10/01 02:38:12, mtomasz wrote:
> nit: this.isSearch -> this.isSearch_

Done.

https://codereview.chromium.org/25263003/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_contents.js:750: * on Drive
File System.
On 2013/10/01 02:38:12, mtomasz wrote:
> nit: Please add a new line after the description for long jsdocs.

Done.

[mtomasz, 2013-10-01 07:47:36]

lgtm with one comment

https://codereview.chromium.org/25263003/diff/9001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/25263003/diff/9001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/directory_contents.js:56: * Starts to
read the entries in the directory.
We don't need to copy jsdoc while overriding. @override is enough.

[hidehiko, 2013-10-01 07:50:38]

Thank you for your review!

https://codereview.chromium.org/25263003/diff/9001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/directory_contents.js (right):

https://codereview.chromium.org/25263003/diff/9001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/directory_contents.js:56: * Starts to
read the entries in the directory.
On 2013/10/01 07:47:36, mtomasz wrote:
> We don't need to copy jsdoc while overriding. @override is enough.

Great to know. Done!

[commit-bot: I haz the power, 2013-10-02 07:50:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/25263003/15001

[commit-bot: I haz the power, 2013-10-02 10:08:25]

Retried try job too often on win_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-02 10:28:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/25263003/15001

[commit-bot: I haz the power, 2013-10-02 15:57:20]

Change committed as 226467