PaymentApp: Add classes for supporting Web Based Payment Apps

chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentAppFactory.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
 import android.content.Context;
 
 import org.chromium.base.VisibleForTesting;
 import org.chromium.content_public.browser.WebContents;
 
 import java.util.ArrayList;
 import java.util.List;
 
 /**
  * Builds instances of payment apps.
  */
 public class PaymentAppFactory {
     /**
      * Can be used to build additional types of payment apps without Chrome knowing about their
      * types.
      */
     private static PaymentAppFactoryAddition sAdditionalFactory;
 
+    private static WebBasedPaymentAppBridge sWebBasedPaymentAppBridge =
+            new WebBasedPaymentAppBridge();
+
     /**
      * The interface for additional payment app factories.
      */
     public interface PaymentAppFactoryAddition {
         /**
          * Builds instances of payment apps.
          *
          * @param context     The application context.
          * @param webContents The web contents that invoked PaymentRequest.
          */
@@ skipping 12 matching lines @@
 
     /**
      * Builds instances of payment apps.
      *
      * @param context     The context.
      * @param webContents The web contents where PaymentRequest was invoked.
      */
     public static List<PaymentApp> create(Context context, WebContents webContents) {
         List<PaymentApp> result = new ArrayList<>(2);
         result.add(new AutofillPaymentApp(context, webContents));
+        result.addAll(createWebBasedPaymentApps(context, webContents));

[please use gerrit instead, 2016/11/29 14:28:44]

Put this behind a command-line flag before it's 100% implemented.

[tommyt, 2016/11/30 13:44:38]

Done.

         if (sAdditionalFactory != null) {
             result.addAll(
                     sAdditionalFactory.create(context, webContents));
         }
         return result;
     }
+
+    /**
+     * Build a WebBasedPaymentApp instance for each installed web based
+     * payment app.
+     *
+     * @param context     The context.
+     * @param webContents The web contents where PaymentRequest was invoked.
+     */
+    private static List<WebBasedPaymentApp> createWebBasedPaymentApps(
+            Context context, WebContents webContents) {

[agrieve, 2016/11/28 17:59:53]

Here and in other places, you should try and say which type of context objects
you expect. If you only want an Application context, then you should remove the
parameter and use ContextUtils.getApplicationContext(). If you expect the
contexts to have limited lifetimes (e.g. activities / services), then you should
state so in order to avoid applications contexts being passed in.

[tommyt, 2016/11/30 13:44:38]

Yeah, this did actually turn out a bit cargo-cult-ish. I put those arguments in
the constructor of my payment app class because the other types of payment app
required these, and I figured I would need them sooner or later too, but that
doesn't seem to be the case. I've removed these two parameters (context and
webContents) from all functions I have introduced.

+        List<WebBasedPaymentApp> result = new ArrayList<>();
+        for (WebBasedPaymentAppBridge.Manifest manifest :
+                sWebBasedPaymentAppBridge.getAllAppManifests()) {
+            result.add(new WebBasedPaymentApp(context, webContents, manifest));
+        }
+        return result;
+    }
 }