third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp - Issue 2526293002: [wrapper-tracing] Untangle non-trivial mixin ctors

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

Issue 2526293002: [wrapper-tracing] Untangle non-trivial mixin ctors (Closed)

Patch Set: s/new BodyStreamBuffer/BodyStreamBuffer::create/ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp ('K') | « third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

index d36427f1d66ab7087d6cadaa1741cdeaa57268ad..be428472d71c2d3c4292398f7cc246cb8dac4f24 100644

--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

@@ -86,7 +86,8 @@ TEST_F(BodyStreamBufferTest, Tee) {

src->add(Command(Command::Data, "hello, "));

src->add(Command(Command::Data, "world"));

src->add(Command(Command::Done));

- BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer* buffer =

+ BodyStreamBuffer::create(scope.getScriptState(), src);

BodyStreamBuffer* new1;

BodyStreamBuffer* new2;

@@ -130,7 +131,7 @@ TEST_F(BodyStreamBufferTest, TeeFromHandleMadeFromStream) {

EXPECT_CALL(checkpoint, Call(4));

BodyStreamBuffer* buffer =

- new BodyStreamBuffer(scope.getScriptState(), stream);

+ BodyStreamBuffer::create(scope.getScriptState(), stream);

BodyStreamBuffer* new1;

BodyStreamBuffer* new2;

@@ -168,7 +169,7 @@ TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandle) {

auto size = data->length();

RefPtr<BlobDataHandle> blobDataHandle =

BlobDataHandle::create(std::move(data), size);

- BodyStreamBuffer* buffer = new BodyStreamBuffer(

+ BodyStreamBuffer* buffer = BodyStreamBuffer::create(

scope.getScriptState(),

new BlobBytesConsumer(scope.getExecutionContext(), blobDataHandle));

@@ -188,7 +189,8 @@ TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandleReturnsNull) {

V8TestingScope scope;

// This BytesConsumer is not drainable.

BytesConsumer* src = new ReplayingBytesConsumer(&scope.document());

- BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer* buffer =

+ BodyStreamBuffer::create(scope.getScriptState(), src);

EXPECT_FALSE(buffer->isStreamLocked());

EXPECT_FALSE(buffer->isStreamDisturbed());

@@ -208,7 +210,7 @@ TEST_F(BodyStreamBufferTest,

ScriptValue stream =

evalWithPrintingError(scope.getScriptState(), "new ReadableStream()");

BodyStreamBuffer* buffer =

- new BodyStreamBuffer(scope.getScriptState(), stream);

+ BodyStreamBuffer::create(scope.getScriptState(), stream);

EXPECT_FALSE(buffer->hasPendingActivity());

EXPECT_FALSE(buffer->isStreamLocked());

@@ -231,7 +233,7 @@ TEST_F(BodyStreamBufferTest, DrainAsFormData) {

data->append("name2", "value2");

RefPtr<EncodedFormData> inputFormData = data->encodeMultiPartFormData();

- BodyStreamBuffer* buffer = new BodyStreamBuffer(

+ BodyStreamBuffer* buffer = BodyStreamBuffer::create(

scope.getScriptState(),

new FormDataBytesConsumer(scope.getExecutionContext(), inputFormData));

@@ -251,7 +253,8 @@ TEST_F(BodyStreamBufferTest, DrainAsFormDataReturnsNull) {

V8TestingScope scope;

// This BytesConsumer is not drainable.

BytesConsumer* src = new ReplayingBytesConsumer(&scope.document());

- BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer* buffer =

+ BodyStreamBuffer::create(scope.getScriptState(), src);

EXPECT_FALSE(buffer->isStreamLocked());

EXPECT_FALSE(buffer->isStreamDisturbed());

@@ -270,7 +273,7 @@ TEST_F(BodyStreamBufferTest,

ScriptValue stream =

evalWithPrintingError(scope.getScriptState(), "new ReadableStream()");

BodyStreamBuffer* buffer =

- new BodyStreamBuffer(scope.getScriptState(), stream);

+ BodyStreamBuffer::create(scope.getScriptState(), stream);

EXPECT_FALSE(buffer->hasPendingActivity());

EXPECT_FALSE(buffer->isStreamLocked());

@@ -301,7 +304,8 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsArrayBuffer) {

src->add(Command(Command::Wait));

src->add(Command(Command::Data, "hello"));

src->add(Command(Command::Done));

- BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer* buffer =

+ BodyStreamBuffer::create(scope.getScriptState(), src);

buffer->startLoading(FetchDataLoader::createLoaderAsArrayBuffer(), client);

EXPECT_TRUE(buffer->isStreamLocked());

@@ -336,7 +340,8 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsBlob) {

src->add(Command(Command::Wait));

src->add(Command(Command::Data, "hello"));

src->add(Command(Command::Done));

- BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer* buffer =

+ BodyStreamBuffer::create(scope.getScriptState(), src);

buffer->startLoading(FetchDataLoader::createLoaderAsBlobHandle("text/plain"),

client);

@@ -368,7 +373,8 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsString) {

src->add(Command(Command::Wait));

src->add(Command(Command::Data, "hello"));

src->add(Command(Command::Done));

- BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer* buffer =

+ BodyStreamBuffer::create(scope.getScriptState(), src);

buffer->startLoading(FetchDataLoader::createLoaderAsString(), client);

EXPECT_TRUE(buffer->isStreamLocked());

@@ -394,7 +400,7 @@ TEST_F(BodyStreamBufferTest, LoadClosedHandle) {

EXPECT_CALL(*client, didFetchDataLoadedString(String("")));

EXPECT_CALL(checkpoint, Call(2));

- BodyStreamBuffer* buffer = new BodyStreamBuffer(

+ BodyStreamBuffer* buffer = BodyStreamBuffer::create(

scope.getScriptState(), BytesConsumer::createClosed());

EXPECT_TRUE(buffer->isStreamClosed());

@@ -422,7 +428,7 @@ TEST_F(BodyStreamBufferTest, LoadErroredHandle) {

EXPECT_CALL(*client, didFetchDataLoadFailed());

EXPECT_CALL(checkpoint, Call(2));

- BodyStreamBuffer* buffer = new BodyStreamBuffer(

+ BodyStreamBuffer* buffer = BodyStreamBuffer::create(

scope.getScriptState(),

BytesConsumer::createErrored(BytesConsumer::Error()));

@@ -456,7 +462,7 @@ TEST_F(BodyStreamBufferTest, LoaderShouldBeKeptAliveByBodyStreamBuffer) {

src->add(Command(Command::Data, "hello"));

src->add(Command(Command::Done));

Persistent<BodyStreamBuffer> buffer =

- new BodyStreamBuffer(scope.getScriptState(), src);

+ BodyStreamBuffer::create(scope.getScriptState(), src);

buffer->startLoading(FetchDataLoader::createLoaderAsString(), client);

ThreadState::current()->collectAllGarbage();

@@ -472,7 +478,7 @@ TEST_F(BodyStreamBufferTest, SourceShouldBeCanceledWhenCanceled) {

scope.getExecutionContext());

BodyStreamBuffer* buffer =

- new BodyStreamBuffer(scope.getScriptState(), consumer);

+ BodyStreamBuffer::create(scope.getScriptState(), consumer);

ScriptValue reason(scope.getScriptState(),

v8String(scope.getScriptState()->isolate(), "reason"));

EXPECT_FALSE(consumer->isCancelled());