Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

chrome/browser/ui/passwords/manage_passwords_view_utils.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
-#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/password_manager/core/browser/affiliation_utils.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/url_formatter/elide_url.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_operations.h"
 #include "ui/gfx/range/range.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 namespace {
 
 // Checks whether two URLs are from the same domain or host.
 bool SameDomainOrHost(const GURL& gurl1, const GURL& gurl2) {
   return net::registry_controlled_domains::SameDomainOrHost(
       gurl1, gurl2,
       net::registry_controlled_domains::INCLUDE_PRIVATE_REGISTRIES);
 }
 
-// TODO(crbug.com/658902): Remove |CheckExpectedPlaceholders| after
-// investigation, including the stringprintf.h #include.
-// Retrieves the string for |string_id| and checks that all expected
-// placeholders are present.
-void CheckExpectedPlaceholders(size_t number_of_placeholders, int string_id) {
-  std::string format_string = l10n_util::GetStringUTF8(string_id);
-  bool success = true;
-
-  for (size_t placeholder = 1; placeholder <= number_of_placeholders;
-       ++placeholder) {
-    std::string placeholder_string = base::StringPrintf("$%zu", placeholder);
-    if (format_string.find(placeholder_string) == std::string::npos) {
-      success = false;
-      LOG(ERROR) << "Expected placeholder " << placeholder_string
-                 << " missing in format_string '" << format_string << "'";
-    }
-  }
-
-  CHECK(success);
-}
-
-// TODO(crbug.com/658902): Remove |CheckReplacementSize| after investigation.
-void CheckReplacementSize(const std::vector<base::string16>& replacements,
-                          size_t expected_size) {
-  if (replacements.size() != expected_size) {
-    LOG(ERROR) << "Expected " << expected_size
-               << " replacements but only found " << replacements.size();
-    // Separated logging from CHECK instead of using CHECK_EQ, because CHECKs in
-    // release builds apparently discard logging (see "CHECK functions discard
-    // their log" in base/logging.h).
-    CHECK(false);
-  }
-}
-
 }  // namespace
 
 gfx::ImageSkia ScaleImageForAccountAvatar(gfx::ImageSkia skia_image) {
   gfx::Size size = skia_image.size();
   if (size.height() != size.width()) {
     gfx::Rect target(size);
     int side = std::min(size.height(), size.width());
     target.ClampToCenteredSize(gfx::Size(side, side));
     skia_image = gfx::ImageSkiaOperations::ExtractSubset(skia_image, target);
   }
@@ skipping 58 matching lines @@
                    : IDS_SAVE_PASSWORD_DIFFERENT_DOMAINS_TITLE;
     replacements.push_back(
         url_formatter::FormatUrlForSecurityDisplay(form_origin_url));
   }
 
   if (is_smartlock_branding_enabled) {
     // "Google Smart Lock" should be a hyperlink.
     base::string16 title_link =
         l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SMART_LOCK);
     replacements.insert(replacements.begin(), title_link);
-    // TODO(crbug.com/658902): Remove |number_of_placeholders| after
-    // investigation.
-    size_t number_of_placeholders = 1;
-    if (title_id == IDS_UPDATE_PASSWORD_DIFFERENT_DOMAINS_TITLE ||
-        title_id == IDS_SAVE_PASSWORD_DIFFERENT_DOMAINS_TITLE) {
-      number_of_placeholders = 2;
+    *title = l10n_util::GetStringFUTF16(title_id, replacements, &offsets);
+    if (!offsets.empty()) {
+      // |offsets| can be empty when the localised string associated with
+      // |title_id| could not be found. While this situation is an error, it
+      // needs to be handled gracefully, see http://crbug.com/658902#c18.
+      *title_link_range =
+          gfx::Range(offsets[0], offsets[0] + title_link.length());
     }
-    CheckExpectedPlaceholders(number_of_placeholders, title_id);
-    CheckReplacementSize(replacements, number_of_placeholders);
-    *title = l10n_util::GetStringFUTF16(title_id, replacements, &offsets);
-    // TODO(crbug.com/658902): Remove this CHECK after investigation.
-    CHECK(!offsets.empty());
-    *title_link_range =
-        gfx::Range(offsets[0], offsets[0] + title_link.length());
   } else {
     replacements.insert(
         replacements.begin(),
         l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_TITLE_BRAND));
     *title = l10n_util::GetStringFUTF16(title_id, replacements, &offsets);
   }
 }
 
 void GetManagePasswordsDialogTitleText(const GURL& user_visible_url,
                                        const GURL& password_origin_url,
@@ skipping 51 matching lines @@
              : form.username_value;
 }
 
 bool IsSyncingAutosignSetting(Profile* profile) {
   const browser_sync::ProfileSyncService* sync_service =
       ProfileSyncServiceFactory::GetForProfile(profile);
   return (sync_service && sync_service->IsFirstSetupComplete() &&
           sync_service->IsSyncActive() &&
           sync_service->GetActiveDataTypes().Has(syncer::PRIORITY_PREFERENCES));
 }