Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252623002: Move the event offsetting logic from ContentView to CVC (Closed)

Created:
6 years, 8 months ago by Yusuf
Modified:
6 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move the event offsetting logic from ContentView to CVC BUG=360664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266586

Patch Set 1 #

Patch Set 2 : Fix missing replacements from event->offset #

Total comments: 4

Patch Set 3 : Nit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 4 chunks +2 lines, -26 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 6 chunks +41 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yusuf
6 years, 8 months ago (2014-04-24 22:59:11 UTC) #1
Yaron
lgtm https://codereview.chromium.org/252623002/diff/20001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/252623002/diff/20001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1218 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1218: boolean consumed = nativeOnTouchEvent(mNativeContentViewCore, offset, nit: extra ws ...
6 years, 8 months ago (2014-04-25 00:33:04 UTC) #2
Yusuf
https://codereview.chromium.org/252623002/diff/20001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/252623002/diff/20001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1218 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1218: boolean consumed = nativeOnTouchEvent(mNativeContentViewCore, offset, On 2014/04/25 00:33:04, Yaron ...
6 years, 8 months ago (2014-04-25 17:21:07 UTC) #3
Yusuf
The CQ bit was checked by yusufo@chromium.org
6 years, 8 months ago (2014-04-25 17:21:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/252623002/40001
6 years, 8 months ago (2014-04-25 22:14:27 UTC) #5
Yusuf
The CQ bit was unchecked by yusufo@chromium.org
6 years, 8 months ago (2014-04-26 05:45:16 UTC) #6
Yusuf
The CQ bit was checked by yusufo@chromium.org
6 years, 7 months ago (2014-04-28 16:19:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/252623002/40001
6 years, 7 months ago (2014-04-28 16:19:53 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 16:20:29 UTC) #9
Message was sent while issue was closed. 
Change committed as 266586

Powered by Google App Engine
This is Rietveld 408576698