Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2526223003: Fix Number.prototype.toString with non-default radix wrt modulo. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Number.prototype.toString with non-default radix wrt modulo. TBR=tebbi@chromium.org BUG=chromium:668510 Committed: https://crrev.com/b6d2bacd66391c0c6e501a810695259ab852a573 Cr-Commit-Position: refs/heads/master@{#41280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/conversions.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M test/mjsunit/number-tostring.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years ago (2016-11-25 07:17:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526223003/1
4 years ago (2016-11-25 07:18:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 07:46:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b6d2bacd66391c0c6e501a810695259ab852a573 Cr-Commit-Position: refs/heads/master@{#41280}
4 years ago (2016-11-25 07:46:45 UTC) #7
Tobias Tebbi
4 years ago (2016-11-28 10:49:26 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698