Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 25262003: Geolocation: add UMA histograms for events and response codes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 78ddae6d05f1f1581dd655b7f28ff1aa3ede9603..bd0b6cdc0952d4f8e8b19b3aba170fccb0d6ddde 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -4853,6 +4853,15 @@ other types of suffix sets.
</summary>
</histogram>
+<histogram name="Geolocation.NetworkLocationRequest.Event"
+ enum="NetworkLocationRequestEvent">
+ <summary>Events in NetworkLocationRequest.</summary>
+</histogram>
+
+<histogram name="Geolocation.NetworkLocationRequest.ResponseCode" units="code">
Ilya Sherman 2013/09/30 21:39:48 nit: I'd recommend either omitting the 'units' att
Michael van Ouwerkerk 2013/10/01 10:28:36 Done.
+ <summary>Http response codes in NetworkLocationRequest.</summary>
+</histogram>
+
<histogram name="GoogleNow.Event" enum="GoogleNowEvent">
<summary>Events in Google Now component extension.</summary>
</histogram>
@@ -24098,6 +24107,16 @@ other types of suffix sets.
<int value="1" label="User Disconnect"/>
</enum>
+<enum name="NetworkLocationRequestEvent" type="int">
+ <int value="0" label="REQUEST_START"/>
+ <int value="1" label="REQUEST_CANCEL"/>
+ <int value="2" label="RESPONSE_SUCCESS"/>
+ <int value="3" label="RESPONSE_NOT_OK"/>
+ <int value="4" label="RESPONSE_EMPTY"/>
+ <int value="5" label="RESPONSE_MALFORMED"/>
+ <int value="6" label="RESPONSE_INVALID_FIX"/>
+</enum>
+
<enum name="NetworkPhyModeType" type="int">
<int value="0" label="UNDEF"/>
<int value="1" label="802.11a"/>

Powered by Google App Engine
This is Rietveld 408576698