Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2526183002: [inspector] revert fallThrough support for async methods (Closed)

Created:
4 years ago by kozy
Modified:
4 years ago
Reviewers:
dgozman, nhiroki
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] revert fallThrough support for async methods We can't use "this" after calling agent code since agent code can destroy dispatcher. BUG=chromium:668358 TBR=dgozman@chromium.org Committed: https://crrev.com/4f798f9065e547074f86df7e45b576387ee82678 Cr-Commit-Position: refs/heads/master@{#41247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/inspector_protocol/README.v8 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
kozy
I've checked locally that it fixed an issue. I'll figure out better solution after holidays. ...
4 years ago (2016-11-24 07:41:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526183002/1
4 years ago (2016-11-24 07:42:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 08:09:16 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-24 08:09:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f798f9065e547074f86df7e45b576387ee82678
Cr-Commit-Position: refs/heads/master@{#41247}

Powered by Google App Engine
This is Rietveld 408576698