Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2526163003: Revert of [test] Add performance test for closures. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Add performance test for closures. (patchset #1 id:1 of https://codereview.chromium.org/2525053002/ ) Reason for revert: Fails on perf. Original issue's description: > [test] Add performance test for closures. > > Short living closures are very common in Node.js. This benchmark tracks progress > as we move the optimizations that are currently only behind > --mark_shared_functions_for_tier_up to the default settings. > > BUG=v8:5512 > > Committed: https://crrev.com/f277da2a00cfd27d44a33a70213a65bd82d0bc95 > Cr-Commit-Position: refs/heads/master@{#41246} TBR=bmeurer@chromium.org,leszeks@chromium.org,franzih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5512 Committed: https://crrev.com/b6ab7996de9f2a14f97ef18ac7f290d976408e7c Cr-Commit-Position: refs/heads/master@{#41261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -91 lines) Patch
D test/js-perf-test/Closures/closures.js View 1 chunk +0 lines, -43 lines 0 comments Download
D test/js-perf-test/Closures/run.js View 1 chunk +0 lines, -26 lines 0 comments Download
M test/js-perf-test/JSTests.json View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [test] Add performance test for closures.
4 years ago (2016-11-24 13:15:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526163003/1
4 years ago (2016-11-24 13:15:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 13:15:42 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-24 13:16:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6ab7996de9f2a14f97ef18ac7f290d976408e7c
Cr-Commit-Position: refs/heads/master@{#41261}

Powered by Google App Engine
This is Rietveld 408576698