Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: components/domain_reliability/dispatcher.h

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: s/&*config/config.get()/g Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/dispatcher.h
diff --git a/components/domain_reliability/dispatcher.h b/components/domain_reliability/dispatcher.h
index 52309e7213e9de3fce1ceccb399371eaac2f2448..0b7175206538aa353eaf83e8a7eb33428d8066eb 100644
--- a/components/domain_reliability/dispatcher.h
+++ b/components/domain_reliability/dispatcher.h
@@ -8,7 +8,6 @@
#include <set>
#include "base/callback.h"
-#include "base/memory/scoped_vector.h"
#include "base/time/time.h"
#include "components/domain_reliability/domain_reliability_export.h"
#include "components/domain_reliability/util.h"
@@ -26,30 +25,17 @@ namespace domain_reliability {
// (See scheduler.h for an explanation of how the intervals are chosen.)
class DOMAIN_RELIABILITY_EXPORT DomainReliabilityDispatcher {
public:
- DomainReliabilityDispatcher(MockableTime* time);
+ explicit DomainReliabilityDispatcher(MockableTime* time);
~DomainReliabilityDispatcher();
- void ScheduleTask(
- const base::Closure& task,
- base::TimeDelta min_delay,
- base::TimeDelta max_delay);
+ void ScheduleTask(const base::Closure& task,
Ryan Sleevi 2014/05/05 19:16:03 Document
Deprecated (see juliatuttle) 2014/05/06 18:52:03 Done.
+ base::TimeDelta min_delay,
+ base::TimeDelta max_delay);
void RunEligibleTasks();
private:
- struct Task {
- Task(const base::Closure& closure_p,
- scoped_ptr<MockableTime::Timer> timer_p,
- base::TimeDelta min_delay_p,
- base::TimeDelta max_delay_p);
- ~Task();
-
- base::Closure closure;
- scoped_ptr<MockableTime::Timer> timer;
- base::TimeDelta min_delay;
- base::TimeDelta max_delay;
- bool eligible;
- };
+ struct Task;
void MakeTaskWaiting(Task* task);
void MakeTaskEligible(Task* task);

Powered by Google App Engine
This is Rietveld 408576698