Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: components/domain_reliability/util.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix one unittest Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/util.cc
diff --git a/components/domain_reliability/util.cc b/components/domain_reliability/util.cc
index d4632bf5e84a044d9ac1ece1611fa993068e44a8..5bb289e2977a6eca345a4592a2f6dcab937298c2 100644
--- a/components/domain_reliability/util.cc
+++ b/components/domain_reliability/util.cc
@@ -20,6 +20,7 @@ class ActualTimer : public MockableTime::Timer {
public:
// Initialize base timer with retain_user_info and is_repeating false.
ActualTimer() : base_timer_(false, false) {}
+
virtual ~ActualTimer() {}
// MockableTime::Timer implementation:
@@ -87,15 +88,16 @@ bool DomainReliabilityUtil::GetBeaconStatus(
else
*beacon_status_out = "ok";
return true;
- } else {
- for (size_t i = 0; i < arraysize(net_error_map); i++) {
- if (net_error_map[i].net_error == net_error) {
- *beacon_status_out = net_error_map[i].beacon_status;
- return true;
- }
+ }
+
+ // TODO(ttuttle): Consider sorting and using binary search?
+ for (size_t i = 0; i < arraysize(net_error_map); i++) {
+ if (net_error_map[i].net_error == net_error) {
+ *beacon_status_out = net_error_map[i].beacon_status;
+ return true;
}
- return false;
}
+ return false;
}
MockableTime::Timer::~Timer() {}

Powered by Google App Engine
This is Rietveld 408576698