Index: components/domain_reliability/util.h |
diff --git a/components/domain_reliability/util.h b/components/domain_reliability/util.h |
index 85c68aadd1b070a35c82ea212026cfadf0ba5053..9f4961857d1aa0a4006e84518c3e4475af28c9e3 100644 |
--- a/components/domain_reliability/util.h |
+++ b/components/domain_reliability/util.h |
@@ -15,18 +15,20 @@ |
namespace domain_reliability { |
-class DOMAIN_RELIABILITY_EXPORT DomainReliabilityUtil { |
- public: |
- // Attempts to convert a net error and an HTTP response code into the status |
- // string that should be recorded in a beacon. Returns true if it could. |
- static bool GetBeaconStatus( |
- int net_error, |
- int http_response_code, |
- std::string* beacon_status_out); |
-}; |
+// Attempts to convert a net error and an HTTP response code into the status |
+// string that should be recorded in a beacon. Returns true if it could. |
+// |
+// N.B.: This functions as the whitelist of "safe" errors to report; network- |
+// local errors are purposefully not converted to avoid revealing |
+// information about the local network to the remote server. |
+bool GetDomainReliabilityBeaconStatus( |
+ int net_error, |
+ int http_response_code, |
+ std::string* beacon_status_out); |
// Mockable wrapper around TimeTicks::Now and Timer. Mock version is in |
// test_util.h. |
+// TODO(ttuttle): Rename to Time{Provider,Source,?}. |
class DOMAIN_RELIABILITY_EXPORT MockableTime { |
public: |
// Mockable wrapper around (a subset of) base::Timer. |
@@ -65,6 +67,7 @@ class DOMAIN_RELIABILITY_EXPORT MockableTime { |
class DOMAIN_RELIABILITY_EXPORT ActualTime : public MockableTime { |
public: |
ActualTime(); |
+ |
virtual ~ActualTime(); |
// MockableTime implementation: |