Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: components/domain_reliability/uploader.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ;_; Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/uploader.h ('k') | components/domain_reliability/uploader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/uploader.cc
diff --git a/components/domain_reliability/uploader.cc b/components/domain_reliability/uploader.cc
index 7112b5f016ee8440970a19b42e66171359bb58d6..e198b2b025dd8fce77596a5b2d35d9ac7a1d498f 100644
--- a/components/domain_reliability/uploader.cc
+++ b/components/domain_reliability/uploader.cc
@@ -38,8 +38,8 @@ const void* UploadUserData::kUserDataKey =
class DomainReliabilityUploaderImpl
: public DomainReliabilityUploader, net::URLFetcherDelegate {
public:
- DomainReliabilityUploaderImpl(
- scoped_refptr<net::URLRequestContextGetter> url_request_context_getter)
+ DomainReliabilityUploaderImpl(const scoped_refptr<
+ net::URLRequestContextGetter>& url_request_context_getter)
: url_request_context_getter_(url_request_context_getter) {}
virtual ~DomainReliabilityUploaderImpl() {
@@ -102,12 +102,12 @@ class DomainReliabilityUploaderImpl
} // namespace
DomainReliabilityUploader::DomainReliabilityUploader() {}
-
DomainReliabilityUploader::~DomainReliabilityUploader() {}
// static
scoped_ptr<DomainReliabilityUploader> DomainReliabilityUploader::Create(
- scoped_refptr<net::URLRequestContextGetter> url_request_context_getter) {
+ const scoped_refptr<net::URLRequestContextGetter>&
+ url_request_context_getter) {
return scoped_ptr<DomainReliabilityUploader>(
new DomainReliabilityUploaderImpl(url_request_context_getter));
}
« no previous file with comments | « components/domain_reliability/uploader.h ('k') | components/domain_reliability/uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698