Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: components/domain_reliability/scheduler_unittest.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ;_; Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/scheduler.cc ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/scheduler_unittest.cc
diff --git a/components/domain_reliability/scheduler_unittest.cc b/components/domain_reliability/scheduler_unittest.cc
index 1d4ef7b165afff2647dc2082ba315254ccfb6b24..9eb96a39debf7eec51ef6d3efd93eaf5fa1803c3 100644
--- a/components/domain_reliability/scheduler_unittest.cc
+++ b/components/domain_reliability/scheduler_unittest.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/time/time.h"
+#include "components/domain_reliability/config.h"
#include "components/domain_reliability/test_util.h"
#include "components/domain_reliability/util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -17,11 +18,10 @@ namespace domain_reliability {
class DomainReliabilitySchedulerTest : public testing::Test {
public:
- DomainReliabilitySchedulerTest() :
- num_collectors_(0),
- params_(CreateDefaultParams()),
- callback_called_(false) {
- }
+ DomainReliabilitySchedulerTest()
+ : num_collectors_(0),
+ params_(CreateDefaultParams()),
+ callback_called_(false) {}
void CreateScheduler(int num_collectors) {
DCHECK_LT(0, num_collectors);
@@ -80,13 +80,11 @@ class DomainReliabilitySchedulerTest : public testing::Test {
}
}
- ::testing::AssertionResult CheckStartingUpload(int expected_collector) {
+ ::testing::AssertionResult CheckStartingUpload(size_t expected_collector) {
DCHECK(scheduler_);
- DCHECK_LE(0, expected_collector);
DCHECK_GT(num_collectors_, expected_collector);
- int collector;
- scheduler_->OnUploadStart(&collector);
+ size_t collector = scheduler_->OnUploadStart();
if (collector == expected_collector)
return ::testing::AssertionSuccess();
@@ -108,7 +106,7 @@ class DomainReliabilitySchedulerTest : public testing::Test {
}
MockTime time_;
- int num_collectors_;
+ size_t num_collectors_;
DomainReliabilityScheduler::Params params_;
scoped_ptr<DomainReliabilityScheduler> scheduler_;
« no previous file with comments | « components/domain_reliability/scheduler.cc ('k') | components/domain_reliability/test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698