Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ;_; Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/monitor.cc ('k') | components/domain_reliability/scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/monitor_unittest.cc
diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc
index b04755f3cfed20bd3d135f3aff2d7a1dff37d370..1366f8df6da77a8094ae8b7acd7866f4bc38dbdf 100644
--- a/components/domain_reliability/monitor_unittest.cc
+++ b/components/domain_reliability/monitor_unittest.cc
@@ -36,6 +36,7 @@ class DomainReliabilityMonitorTest : public testing::Test {
base::MessageLoopProxy::current())),
time_(new MockTime()),
monitor_(url_request_context_getter_->GetURLRequestContext(),
+ "test-reporter",
scoped_ptr<MockableTime>(time_)),
context_(monitor_.AddContextForTesting(CreateConfig())) {}
@@ -86,9 +87,9 @@ class DomainReliabilityMonitorTest : public testing::Test {
return request;
}
- bool CheckNoBeacons(int index) {
+ bool CheckNoBeacons(size_t index) {
BeaconVector beacons;
- int successful, failed;
+ unsigned successful, failed;
context_->GetQueuedDataForTesting(index, &beacons, &successful, &failed);
return beacons.empty() && successful == 0 && failed == 0;
}
@@ -156,6 +157,7 @@ TEST_F(DomainReliabilityMonitorTest, AddBakedInConfigs) {
// source tree.
monitor_.AddBakedInConfigs();
+ // Count the number of baked-in configs.
size_t num_baked_in_configs = 0;
for (const char* const* p = kBakedInJsonConfigs; *p; ++p)
++num_baked_in_configs;
« no previous file with comments | « components/domain_reliability/monitor.cc ('k') | components/domain_reliability/scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698