Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: components/domain_reliability/dispatcher.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: ;_; Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/dispatcher.cc
diff --git a/components/domain_reliability/dispatcher.cc b/components/domain_reliability/dispatcher.cc
index ceb4da09c8b5e6ca76129831eacb696cb93af012..e5e11ccaf94c9835a66b973409e7760a50d9f972 100644
--- a/components/domain_reliability/dispatcher.cc
+++ b/components/domain_reliability/dispatcher.cc
@@ -12,6 +12,32 @@
namespace domain_reliability {
+struct DomainReliabilityDispatcher::Task {
+ Task(const base::Closure& closure,
+ scoped_ptr<MockableTime::Timer> timer,
+ base::TimeDelta min_delay,
+ base::TimeDelta max_delay);
+ ~Task();
+
+ base::Closure closure;
+ scoped_ptr<MockableTime::Timer> timer;
+ base::TimeDelta min_delay;
+ base::TimeDelta max_delay;
+ bool eligible;
+};
+
+DomainReliabilityDispatcher::Task::Task(const base::Closure& closure,
+ scoped_ptr<MockableTime::Timer> timer,
+ base::TimeDelta min_delay,
+ base::TimeDelta max_delay)
+ : closure(closure),
+ timer(timer.Pass()),
+ min_delay(min_delay),
+ max_delay(max_delay),
+ eligible(false) {}
+
+DomainReliabilityDispatcher::Task::~Task() {}
+
DomainReliabilityDispatcher::DomainReliabilityDispatcher(MockableTime* time)
: time_(time) {}
@@ -56,29 +82,15 @@ void DomainReliabilityDispatcher::RunEligibleTasks() {
}
}
-DomainReliabilityDispatcher::Task::Task(const base::Closure& closure,
- scoped_ptr<MockableTime::Timer> timer,
- base::TimeDelta min_delay,
- base::TimeDelta max_delay)
- : closure(closure),
- timer(timer.Pass()),
- min_delay(min_delay),
- max_delay(max_delay),
- eligible(false) {}
-
-DomainReliabilityDispatcher::Task::~Task() {}
-
void DomainReliabilityDispatcher::MakeTaskWaiting(Task* task) {
DCHECK(task);
DCHECK(!task->eligible);
DCHECK(!task->timer->IsRunning());
- task->timer->Start(
- FROM_HERE,
- task->min_delay,
- base::Bind(
- &DomainReliabilityDispatcher::MakeTaskEligible,
- base::Unretained(this),
- task));
+ task->timer->Start(FROM_HERE,
+ task->min_delay,
+ base::Bind(&DomainReliabilityDispatcher::MakeTaskEligible,
+ base::Unretained(this),
+ task));
}
void
@@ -87,13 +99,11 @@ DomainReliabilityDispatcher::MakeTaskEligible(Task* task) {
DCHECK(!task->eligible);
task->eligible = true;
eligible_tasks_.insert(task);
- task->timer->Start(
- FROM_HERE,
- task->max_delay - task->min_delay,
- base::Bind(
- &DomainReliabilityDispatcher::RunAndDeleteTask,
- base::Unretained(this),
- task));
+ task->timer->Start(FROM_HERE,
+ task->max_delay - task->min_delay,
+ base::Bind(&DomainReliabilityDispatcher::RunAndDeleteTask,
+ base::Unretained(this),
+ task));
}
void DomainReliabilityDispatcher::RunAndDeleteTask(Task* task) {
« no previous file with comments | « components/domain_reliability/dispatcher.h ('k') | components/domain_reliability/domain_reliability_export.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698