components/domain_reliability/beacon.cc - Issue 252613002: Domain Reliability: More security review.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/domain_reliability/beacon.cc

Issue 252613002: Domain Reliability: More security review. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/domain_reliability/beacon.cc

diff --git a/components/domain_reliability/beacon.cc b/components/domain_reliability/beacon.cc

index 8b738114ad0d808050880f360b0d320e5e97eda5..f826a20344e5c4c3192dd4948e04094c023de7b2 100644

--- a/components/domain_reliability/beacon.cc

+++ b/components/domain_reliability/beacon.cc

@@ -31,8 +31,6 @@ Value* DomainReliabilityBeacon::ToValue(base::TimeTicks upload_time) const {

elapsed.InMilliseconds());

beacon_value->SetInteger("request_age_ms",

(upload_time - start_time).InMilliseconds());

- // TODO(ttuttle): Implement protocol and dns_resolver_ip[s] fields.

return beacon_value;

}