Domain Reliability: More security review.

components/domain_reliability/context.h

Index: components/domain_reliability/context.h
diff --git a/components/domain_reliability/context.h b/components/domain_reliability/context.h
index 2a8a9e169a52272abf3657d889184657a5033232..1d425c95dcc1f49876473ae8edf839c94392fc2f 100644
--- a/components/domain_reliability/context.h
+++ b/components/domain_reliability/context.h
@@ -38,6 +38,9 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityContext {
       scoped_ptr<const DomainReliabilityConfig> config);
   virtual ~DomainReliabilityContext();

[Ryan Sleevi, 2014/04/25 01:00:02]

Why is this virtual, when you have no virtual methods and are not implementing
any interfaces?

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Done.

 
+  // Adds a beacon; may or may not save the actual beacon to be uploaded,
+  // depending on the sample rates in the config, but will increment one of
+  // the request counters in any case.

[Ryan Sleevi, 2014/04/25 01:00:02]

Should this be called "RegisterBeacon" instead? Or something more event-notify'y
like "OnBeacon"?

The "add" in AddBeacon seems like it will take some concrete step with the
Beacon being added to something, but that's not entirely the case. Yes, you
increment the request counters, but you don't add the beacon to be uploaded,
which is the first thing I think of with "AddBeacon"

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Yeah, I've never been happy with this name. I think OnBeacon is better enough.

   void AddBeacon(const DomainReliabilityBeacon& beacon, const GURL& url);
 
   void GetQueuedDataForTesting(