Domain Reliability: More security review.

components/domain_reliability/beacon.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/beacon.h"
 
 #include "base/values.h"
 #include "net/base/net_errors.h"
 
 namespace domain_reliability {
 
 using base::Value;
 using base::DictionaryValue;
 
 DomainReliabilityBeacon::DomainReliabilityBeacon() {}
 DomainReliabilityBeacon::~DomainReliabilityBeacon() {}
 
 Value* DomainReliabilityBeacon::ToValue(base::TimeTicks upload_time) const {
   DictionaryValue* beacon_value = new DictionaryValue();
   beacon_value->SetString("status", status);
   if (chrome_error != net::OK) {
     DictionaryValue* failure_value = new DictionaryValue();
     failure_value->SetString("custom_error",
                              net::ErrorToString(chrome_error));

[Ryan Sleevi, 2014/05/05 19:16:03]

is "custom_error" really the right name for this? Isn't this the internal name?

That is, it doesn't go out as part of the beacon (that goes out as 'status')

[Deprecated (see juliatuttle), 2014/05/06 18:52:03]

Yes, this is the internal name; it's partially redundant, and there just in case
we end up mapping multiple errors to the same status code.

     beacon_value->Set("failure_data", failure_value);
   }
   beacon_value->SetString("server_ip", server_ip);
   if (http_response_code >= 0)
     beacon_value->SetInteger("http_response_code", http_response_code);
   beacon_value->SetInteger("request_elapsed_ms",
                            elapsed.InMilliseconds());
   beacon_value->SetInteger("request_age_ms",
                            (upload_time - start_time).InMilliseconds());
-  // TODO(ttuttle): Implement protocol and dns_resolver_ip[s] fields.
-
   return beacon_value;
 }
 
 }  // namespace domain_reliability