Domain Reliability: More security review.

components/domain_reliability/util.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_UTIL_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_UTIL_H_
 
 #include <map>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/time/time.h"
 #include "base/tracked_objects.h"
 #include "components/domain_reliability/domain_reliability_export.h"
 
 namespace domain_reliability {
 
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityUtil {
  public:
   // Attempts to convert a net error and an HTTP response code into the status
   // string that should be recorded in a beacon. Returns true if it could.

[Ryan Sleevi, 2014/04/30 23:58:11]

1) Better documentation needed, since it still tripped me up in this review that
this implemented the whitelist, and not just an 'accidental omission'
2) Per
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Nonmem...
, this shouldn't be a static method in a class. Probably just a free-standing fn
in the domain_reliability namespace

[Deprecated (see juliatuttle), 2014/05/02 19:23:40]

Done.

   static bool GetBeaconStatus(
       int net_error,
       int http_response_code,
       std::string* beacon_status_out);
 };
 
 // Mockable wrapper around TimeTicks::Now and Timer. Mock version is in
 // test_util.h.
+// TODO(ttuttle): Rename to Time{Provider,Source,?}.
 class DOMAIN_RELIABILITY_EXPORT MockableTime {
  public:
   // Mockable wrapper around (a subset of) base::Timer.
   class DOMAIN_RELIABILITY_EXPORT Timer {
    public:
     virtual ~Timer();
 
     virtual void Start(const tracked_objects::Location& posted_from,
                        base::TimeDelta delay,
                        const base::Closure& user_task) = 0;
@@ skipping 18 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockableTime);
 };
 
 // Implementation of MockableTime that passes through to
 // base::Time{,Ticks}::Now() and base::Timer.
 class DOMAIN_RELIABILITY_EXPORT ActualTime : public MockableTime {
  public:
   ActualTime();
+
   virtual ~ActualTime();
 
   // MockableTime implementation:
   virtual base::Time Now() OVERRIDE;
   virtual base::TimeTicks NowTicks() OVERRIDE;
   virtual scoped_ptr<MockableTime::Timer> CreateTimer() OVERRIDE;
 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_UTIL_H_