Domain Reliability: More security review.

components/domain_reliability/uploader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/uploader.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_vector.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/stl_util.h"
@@ skipping 20 matching lines @@
     return new UploadUserData();
   }
 };
 
 const void* UploadUserData::kUserDataKey =
     static_cast<const void*>(&UploadUserData::kUserDataKey);
 
 class DomainReliabilityUploaderImpl
     : public DomainReliabilityUploader, net::URLFetcherDelegate {
  public:
-  DomainReliabilityUploaderImpl(
-      scoped_refptr<net::URLRequestContextGetter> url_request_context_getter)
+  DomainReliabilityUploaderImpl(const scoped_refptr<
+      net::URLRequestContextGetter>& url_request_context_getter)
       : url_request_context_getter_(url_request_context_getter) {}
 
   virtual ~DomainReliabilityUploaderImpl() {
     // Delete any in-flight URLFetchers.
     STLDeleteContainerPairFirstPointers(
         upload_callbacks_.begin(), upload_callbacks_.end());
   }
 
   // DomainReliabilityUploader implementation:
   virtual void UploadReport(
@@ skipping 42 matching lines @@
   using DomainReliabilityUploader::UploadCallback;
   typedef std::map<const net::URLFetcher*, UploadCallback> UploadCallbackMap;
 
   scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
   UploadCallbackMap upload_callbacks_;
 };
 
 }  // namespace
 
 DomainReliabilityUploader::DomainReliabilityUploader() {}
-
 DomainReliabilityUploader::~DomainReliabilityUploader() {}
 
 // static
 scoped_ptr<DomainReliabilityUploader> DomainReliabilityUploader::Create(
-    scoped_refptr<net::URLRequestContextGetter> url_request_context_getter) {
+    const scoped_refptr<net::URLRequestContextGetter>&
+        url_request_context_getter) {
   return scoped_ptr<DomainReliabilityUploader>(
       new DomainReliabilityUploaderImpl(url_request_context_getter));
 }
 
 // static
 bool DomainReliabilityUploader::URLRequestIsUpload(
     const net::URLRequest& request) {
   return request.GetUserData(UploadUserData::kUserDataKey) != NULL;
 }
 
 }  // namespace domain_reliability