Domain Reliability: More security review.

components/domain_reliability/bake_in_configs.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Takes the JSON files in components/domain_reliability/baked_in_configs and
 encodes their contents as an array of C strings that gets compiled in to Chrome
 and loaded at runtime."""
 
@@ skipping 60 matching lines @@
 
 
 def main():
   if len(sys.argv) < 3:
     print >> sys.stderr, ('Usage: %s <JSON files...> <output C++ file>' %
                           sys.argv[0])
     print >> sys.stderr, sys.modules[__name__].__doc__
     return 1
 
   cpp_code = CC_HEADER
-  cpp_file = sys.argv[-1]
   for json_file in sys.argv[1:-1]:
     with open(json_file, 'r') as f:
       json_text = f.read()
     config = json.loads(json_text)
     if 'monitored_domain' not in config:
       print >> sys.stderr ('%s: no monitored_domain found' % json_file)
       return 1
     domain = config['monitored_domain']
     if not domain_is_whitelisted(domain):
       print >> sys.stderr ('%s: monitored_domain "%s" not in whitelist' %
                            (json_file, domain))
       return 1
     cpp_code += "  // " + json_file + ":\n"
     cpp_code += quote_and_wrap_text(json_text) + ",\n"
     cpp_code += "\n"
   cpp_code += CC_FOOTER
 
-  with open(cpp_file, 'wb') as f:
+  with open(sys.argv[-1], 'wb') as f:
     f.write(cpp_code)
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())