Domain Reliability: More security review.

components/domain_reliability/uploader_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/uploader.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 28 matching lines @@
     EXPECT_FALSE(upload_complete_[index]);
     upload_complete_[index] = true;
     upload_successful_[index] = success;
   }
 
   content::TestBrowserThreadBundle test_browser_thread_bundle_;
   net::TestURLFetcherFactory url_fetcher_factory_;
   scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
   scoped_ptr<DomainReliabilityUploader> uploader_;
 
+  // Whether the upload callback was called for a particular collector index.
   std::map<int, bool> upload_complete_;
+  // Whether the upload to a particular collector was successful.
   std::map<int, bool> upload_successful_;

[Ryan Sleevi, 2014/04/26 02:37:39]

size_t

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Done.

 };
 
 TEST_F(DomainReliabilityUploaderTest, Create) {
   net::TestURLFetcher* fetcher;
 
   fetcher = url_fetcher_factory_.GetFetcherByID(0);
   EXPECT_FALSE(fetcher);
 }
 
 TEST_F(DomainReliabilityUploaderTest, SuccessfulUpload) {
@@ skipping 36 matching lines @@
   fetcher->set_response_code(500);
   fetcher->SetResponseString("");
 
   EXPECT_FALSE(upload_complete_[0]);
   fetcher->delegate()->OnURLFetchComplete(fetcher);
   EXPECT_TRUE(upload_complete_[0]);
   EXPECT_FALSE(upload_successful_[0]);
 }
 
 }  // namespace domain_reliability