Domain Reliability: More security review.

components/domain_reliability/uploader.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_
 
 #include <map>
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "components/domain_reliability/domain_reliability_export.h"
 #include "url/gurl.h"
 
 namespace net {
 class URLFetcher;
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace domain_reliability {
 
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityUploader {

[Ryan Sleevi, 2014/04/26 02:37:39]

Document.

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Done.

  public:
   typedef base::Callback<void(bool success)> UploadCallback;
 
   DomainReliabilityUploader();
+
   virtual ~DomainReliabilityUploader();
 
   static scoped_ptr<DomainReliabilityUploader> Create(
       scoped_refptr<net::URLRequestContextGetter> url_request_context_getter);

[Ryan Sleevi, 2014/04/26 02:37:39]

const scoped_refptr<...>&

Avoids an extra refcount cycle, still has the same effect.

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Done.

 
   virtual void UploadReport(const std::string& report_json,

[Ryan Sleevi, 2014/04/26 02:37:39]

Document.

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Done.

                             const GURL& upload_url,
                             const UploadCallback& callback) = 0;
 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_UPLOADER_H_