Domain Reliability: More security review.

components/domain_reliability/beacon.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOMAIN_RELIABILITY_BEACON_H_
 #define COMPONENTS_DOMAIN_RELIABILITY_BEACON_H_
 
 #include <string>
 
 #include "base/time/time.h"
 #include "components/domain_reliability/domain_reliability_export.h"
 
 namespace base {
 class Value;
 }  // namespace base
 
 namespace domain_reliability {
 
 // The per-request data that is uploaded to the Domain Reliability collector.
 class DOMAIN_RELIABILITY_EXPORT DomainReliabilityBeacon {

[Ryan Sleevi, 2014/04/25 01:00:02]

Why is this a class and not a struct?

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Struct...

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

Done.

  public:
   DomainReliabilityBeacon();
   ~DomainReliabilityBeacon();
 
   // Converts the Beacon to JSON format for uploading. Calculates the age
   // relative to an upload time of |upload_time|.
   base::Value* ToValue(base::TimeTicks upload_time) const;
 
   // Status string (e.g. "ok", "dns.nxdomain", "http.403").
   std::string status;
   // Net error code.  Encoded as a string in the final JSON.
   int chrome_error;
   // IP address of the server the request went to.
   std::string server_ip;
   // HTTP response code returned by the server, or -1 if none was received.
   int http_response_code;
   // Elapsed time between starting and completing the request.
   base::TimeDelta elapsed;
   // Start time of the request.  Encoded as the request age in the final JSON.
   base::TimeTicks start_time;
 
-  // Okay to copy and assign :)
+  // Okay to copy and assign. ^_^

[Ryan Sleevi, 2014/04/25 01:00:02]

No need for emoticons either way.

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

:(

Done.

 };
 
 }  // namespace domain_reliability
 
 #endif  // COMPONENTS_DOMAIN_RELIABILITY_BEACON_H_