Domain Reliability: More security review.

components/domain_reliability/beacon.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/beacon.h"
 
 #include "base/values.h"
 #include "net/base/net_errors.h"
 
 namespace domain_reliability {
 
 using base::Value;
 using base::DictionaryValue;
 
 DomainReliabilityBeacon::DomainReliabilityBeacon() {}
 DomainReliabilityBeacon::~DomainReliabilityBeacon() {}
 
 Value* DomainReliabilityBeacon::ToValue(base::TimeTicks upload_time) const {
   DictionaryValue* beacon_value = new DictionaryValue();
   beacon_value->SetString("status", status);
   if (chrome_error != net::OK) {
     DictionaryValue* failure_value = new DictionaryValue();
     failure_value->SetString("custom_error",
                              net::ErrorToString(chrome_error));

[Ryan Sleevi, 2014/04/25 01:00:02]

I don't think we should be arbitrarily providing the error code, for two
reasons:

1) It makes our internal error codes a de-facto public API (unless this is
clearly documented as 'informative and subject to change'). Still, I have strong
fear this will end up being "user agent strings" all over again (eg: we can't
change because people expect X to happen)

2) This leaks a variety of state about the clients' local network configuration
that the remote site would otherwise be unable or unauthorized to view. If we do
this, we need to sit down and create an explicit whitelist of errors we "know"
will never contain private data or would otherwise be detectable by the server.

[Deprecated (see juliatuttle), 2014/04/28 22:01:13]

We can document it as that; right now, it's not documented at all.
We have that whitelist already; it's in DomainReliabilityUtil::GetBeaconStatus.
Without an entry in that mapping, we won't report the request at all.

     beacon_value->Set("failure_data", failure_value);
   }
   beacon_value->SetString("server_ip", server_ip);
   if (http_response_code >= 0)
     beacon_value->SetInteger("http_response_code", http_response_code);
   beacon_value->SetInteger("request_elapsed_ms",
                            elapsed.InMilliseconds());
   beacon_value->SetInteger("request_age_ms",
                            (upload_time - start_time).InMilliseconds());
-  // TODO(ttuttle): Implement protocol and dns_resolver_ip[s] fields.
-
   return beacon_value;
 }
 
 }  // namespace domain_reliability