dart2js-kernel: Implement Let and PropertySet.

dart2js-kernel: Implement Let and PropertySet.

The Accessor builders capture some subexpressions to help map kernel
Nodes to Ast Nodes.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/b20b10a0af183c285dada2bf7a6b4d681065946e

[sra1, 2016-11-24 03:15:51]

sra@google.com changed reviewers:
+ asgerf@google.com, sigmund@google.com

[sra1, 2016-11-24 03:15:51]

Asger - I would value your opinion on the capturing of subexpressions.

[asgerf, 2016-11-24 09:44:33]

LGTM if PropertySet is fixed

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/kernel_visitor.dart (right):

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/kernel_visitor.dart:2325: return buildCompound(new
ReadOnlyAccessor(buildTypeLiteral(constant)), rhs, node);
long line

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/kernel_visitor.dart:2335: return buildCompound(new
ReadOnlyAccessor(buildTypeVariable(element)), rhs, node);
long line

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:964: <HInstruction>[receiver,
value]);
PropertySet should evaluate to its right-hand side, not the value returned from
the call.

I'll update the documentation in the kernel AST to make this clear.

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1487: print('visitMethodInvocation 
${invocation}');
Stray print

https://codereview.chromium.org/2526123002/diff/1/pkg/kernel/lib/frontend/acc...
File pkg/kernel/lib/frontend/accessors.dart (right):

https://codereview.chromium.org/2526123002/diff/1/pkg/kernel/lib/frontend/acc...
pkg/kernel/lib/frontend/accessors.dart:17: Expression builtGetter;
LGTM

https://codereview.chromium.org/2526123002/diff/1/pkg/kernel/lib/frontend/acc...
pkg/kernel/lib/frontend/accessors.dart:150: _makeRead() => builtGetter = new
PropertyGet(new ThisExpression(), name, getter);
Long line (please use dartfmt in pkg/kernel)

[sra1, 2016-11-24 23:53:52]

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/kernel_visitor.dart (right):

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/kernel_visitor.dart:2325: return buildCompound(new
ReadOnlyAccessor(buildTypeLiteral(constant)), rhs, node);
On 2016/11/24 09:44:32, asgerf wrote:
> long line

Done.

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/kernel_visitor.dart:2335: return buildCompound(new
ReadOnlyAccessor(buildTypeVariable(element)), rhs, node);
On 2016/11/24 09:44:32, asgerf wrote:
> long line

Done.

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:964: <HInstruction>[receiver,
value]);
On 2016/11/24 09:44:32, asgerf wrote:
> PropertySet should evaluate to its right-hand side, not the value returned
from
> the call.
> 
> I'll update the documentation in the kernel AST to make this clear.

Done.

https://codereview.chromium.org/2526123002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1487: print('visitMethodInvocation 
${invocation}');
On 2016/11/24 09:44:32, asgerf wrote:
> Stray print

Done.

https://codereview.chromium.org/2526123002/diff/1/pkg/kernel/lib/frontend/acc...
File pkg/kernel/lib/frontend/accessors.dart (right):

https://codereview.chromium.org/2526123002/diff/1/pkg/kernel/lib/frontend/acc...
pkg/kernel/lib/frontend/accessors.dart:17: Expression builtGetter;
On 2016/11/24 09:44:33, asgerf wrote:
> LGTM

Acknowledged.

https://codereview.chromium.org/2526123002/diff/1/pkg/kernel/lib/frontend/acc...
pkg/kernel/lib/frontend/accessors.dart:150: _makeRead() => builtGetter = new
PropertyGet(new ThisExpression(), name, getter);
On 2016/11/24 09:44:33, asgerf wrote:
> Long line (please use dartfmt in pkg/kernel)

Done.

[sra1, 2016-11-26 20:42:50]

Description was changed from

==========
dart2js-kernel: Implement Let and PropertySet.

The Accessor builders capture some subexpressions to help map kernel
Nodes to Ast Nodes.
==========

to

==========
dart2js-kernel: Implement Let and PropertySet.

The Accessor builders capture some subexpressions to help map kernel
Nodes to Ast Nodes.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b20b10a0af183c285dada2bf7a6b4d681065946e
==========

[sra1, 2016-11-26 20:42:51]

Committed patchset #2 (id:20001) manually as
b20b10a0af183c285dada2bf7a6b4d681065946e (presubmit successful).

[Siggi Cherem (dart-lang), 2016-11-28 16:11:09]

lgtm