Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2526073003: Re-add the line break attribute (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/blink_ax_tree_source.cc
diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc
index f97a7548cd0737fcbb6b4ea079e5c8393d5ed751..937f786e432515ea48f07e009b6132b0e40228c2 100644
--- a/content/renderer/accessibility/blink_ax_tree_source.cc
+++ b/content/renderer/accessibility/blink_ax_tree_source.cc
@@ -547,7 +547,19 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
if (src.isEditable()) {
dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, src.selectionStart());
dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, src.selectionEnd());
+
+#if defined(OS_CHROMEOS)
dmazzoni 2016/11/28 17:41:38 Add a comment with a bug link
David Tseng 2016/11/28 19:13:01 Done.
+ WebVector<int> src_line_breaks;
+ src.lineBreaks(src_line_breaks);
+ if (src_line_breaks.size()) {
+ std::vector<int32_t> line_breaks;
+ line_breaks.reserve(src_line_breaks.size());
+ for (size_t i = 0; i < src_line_breaks.size(); ++i)
+ line_breaks.push_back(src_line_breaks[i]);
+ dst->AddIntListAttribute(ui::AX_ATTR_LINE_BREAKS, line_breaks);
+ }
}
dmazzoni 2016/11/28 17:41:38 I think this closing brace belongs outside of the
David Tseng 2016/11/28 19:13:01 Done.
+#endif // defined OS_CHROMEOS
// ARIA role.
if (element.hasAttribute("role")) {

Powered by Google App Engine
This is Rietveld 408576698