Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/inspector/injected-script-source.js

Issue 2526073002: Previews should exclude a property if its name is a symbol (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/inspector/runtime/evaluate-with-generate-preview.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 925 matching lines...) Expand 10 before | Expand all | Expand 10 after
936 if (!descriptor.isOwn) 936 if (!descriptor.isOwn)
937 continue; 937 continue;
938 938
939 // Ignore computed properties unless they have getters. 939 // Ignore computed properties unless they have getters.
940 if (!("value" in descriptor)) { 940 if (!("value" in descriptor)) {
941 if (descriptor.get) 941 if (descriptor.get)
942 this._appendPropertyPreview(preview, { name: name, type: "ac cessor", __proto__: null }, propertiesThreshold); 942 this._appendPropertyPreview(preview, { name: name, type: "ac cessor", __proto__: null }, propertiesThreshold);
943 continue; 943 continue;
944 } 944 }
945 945
946 // Never preview symbols.
947 if (descriptor.symbol)
948 continue;
949
946 var value = descriptor.value; 950 var value = descriptor.value;
947 var type = typeof value; 951 var type = typeof value;
948 952
949 // Never render functions in object preview. 953 // Never render functions in object preview.
950 if (type === "function" && (this.subtype !== "array" || !isUInt32(na me))) 954 if (type === "function" && (this.subtype !== "array" || !isUInt32(na me)))
951 continue; 955 continue;
952 956
953 // Special-case HTMLAll. 957 // Special-case HTMLAll.
954 if (type === "undefined" && injectedScript._isHTMLAllCollection(valu e)) 958 if (type === "undefined" && injectedScript._isHTMLAllCollection(valu e))
955 type = "object"; 959 type = "object";
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1065 return string.substr(0, leftHalf) + "\u2026" + string.substr(string. length - rightHalf, rightHalf); 1069 return string.substr(0, leftHalf) + "\u2026" + string.substr(string. length - rightHalf, rightHalf);
1066 } 1070 }
1067 return string.substr(0, maxLength) + "\u2026"; 1071 return string.substr(0, maxLength) + "\u2026";
1068 }, 1072 },
1069 1073
1070 __proto__: null 1074 __proto__: null
1071 } 1075 }
1072 1076
1073 return injectedScript; 1077 return injectedScript;
1074 }) 1078 })
OLDNEW
« no previous file with comments | « no previous file | test/inspector/runtime/evaluate-with-generate-preview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698