Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2526063002: Add parser support for using a URI in a part-of directive (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add parser support for using a URI in a part-of directive R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b923dafd253657b9ecb38e316ca3f37d0afe7846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -27 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 2 chunks +19 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 4 chunks +18 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +32 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 5 chunks +56 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 4 chunks +24 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Support is not complete, but does allow for parsing. Getting this in now will mean ...
4 years ago (2016-11-23 22:20:51 UTC) #2
scheglov
LGTM
4 years ago (2016-11-23 23:44:50 UTC) #3
Brian Wilkerson
4 years ago (2016-11-25 16:16:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b923dafd253657b9ecb38e316ca3f37d0afe7846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698